986658 - [Camera][Madai][UX] 1.4 Dual Shutter on press state should show stop icon

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect, P1)

Description

[Amy Lee [:amylee] UX]

When the user holds down on the record video button, the white circle expands and changes to red but the stop icon is missing until you release the button. 

The stop icon (white square) should appear on pressed state and not on release.

Comment 1

[Youngjun Kim]

After landing our features, Hyuna will take it.

Comment 2

[hyuna.cho]

Please check the latest version for dual shutter.
You can check the dual shutter and image capturing during the recording.

Comment 3

[Amy Lee [:amylee] UX]

(In reply to hyuna.cho from comment #2)
> Please check the latest version for dual shutter.
> You can check the dual shutter and image capturing during the recording.

Hi Hyuna, 

Here's my feedback:

On press the square shows up but it grows to a bigger size on release. The square should be the same size on press and on release. 

Also I noticed that when you tap the shutter button to take a photo. The blue highlight state doesn't show up. You have to hold down on the shutter button to get it to highlight. Should I file a separate bug for this? 

Thanks Hyuna

Comment 4

[Youngjun Kim]

Hyuna will share new source version to review it from Amy.

Comment 5

[hyuna.cho]

(In reply to Amy from comment #3)
> (In reply to hyuna.cho from comment #2)
> > Please check the latest version for dual shutter.
> > You can check the dual shutter and image capturing during the recording.
> 
> Hi Hyuna, 
> 
> Here's my feedback:
> 
> On press the square shows up but it grows to a bigger size on release. The
> square should be the same size on press and on release. 

The square size is 1.6 rem on press and the size is bigger x1.4 on release.
Can I resize?


> Also I noticed that when you tap the shutter button to take a photo. The
> blue highlight state doesn't show up. You have to hold down on the shutter
> button to get it to highlight. Should I file a separate bug for this?

When tap the shutter button quickly or around white edge, sometimes the blue highlight state doesn't show up.
It reproduce in the single button also. Please file a separate bug.

> Thanks Hyuna

Comment 6

[Amy Lee [:amylee] UX]

(In reply to hyuna.cho from comment #5)
> (In reply to Amy from comment #3)
> > (In reply to hyuna.cho from comment #2)
> > > Please check the latest version for dual shutter.
> > > You can check the dual shutter and image capturing during the recording.
> > 
> > Hi Hyuna, 
> > 
> > Here's my feedback:
> > 
> > On press the square shows up but it grows to a bigger size on release. The
> > square should be the same size on press and on release. 
> 
> The square size is 1.6 rem on press and the size is bigger x1.4 on release.
> Can I resize?

I found this bug which fixes the issue:

https://bugzilla.mozilla.org/show_bug.cgi?id=985680

Does this mean this bug can be closed?

Comment 7

[hyuna.cho]

(In reply to Amy from comment #6)
> (In reply to hyuna.cho from comment #5)
> > (In reply to Amy from comment #3)
> > > (In reply to hyuna.cho from comment #2)
> > > > Please check the latest version for dual shutter.
> > > > You can check the dual shutter and image capturing during the recording.
> > > 
> > > Hi Hyuna, 
> > > 
> > > Here's my feedback:
> > > 
> > > On press the square shows up but it grows to a bigger size on release. The
> > > square should be the same size on press and on release. 
> > 
> > The square size is 1.6 rem on press and the size is bigger x1.4 on release.
> > Can I resize?
> 
> I found this bug which fixes the issue:
> 
> https://bugzilla.mozilla.org/show_bug.cgi?id=985680
> 
> Does this mean this bug can be closed?

https://bugzilla.mozilla.org/show_bug.cgi?id=985680
It's a record button in single button mode. It's not affect to dual shutter.

You said about red dot size of the dual shutter mode in this bug.
If you feel the red dot looks good, can be close this bug.

Comment 8

[Youngjun Kim]

Dear Amy,

As Hyuna's comment 7, we need your confirmation to close this issue.

Comment 9

[Amy Lee [:amylee] UX]

(In reply to Youngjun Kim from comment #8)
> Dear Amy,
> 
> As Hyuna's comment 7, we need your confirmation to close this issue.

Hi Hyuna, 

This looks good. This issue can be closed. Thanks!

Comment 10

[Youngjun Kim]

As Amy's comment 9, we can close it.