986927 - test-attachment-menus.js fails if message reader size changes

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Philipp Kewisch [:Fallen][📱📆]]

test-attachment-menus.js does a right click on #attachmentList with the intent to open the context menu #attachmentListContext. When there are attachments in #attachmentList, each has its own context menu #attachmentItemContext. test-window-helpers augments the rightClick function to always click in the middle of the node.

With the current UI, test-attachment-menus works fine because by coincidence the middle of #attachmentList is not over an attachment item. With Lightning enabled, the today pane takes up a bit more space and the middle of #attachmentList turns out to be an attachment item.

The upcoming patch modifies the behavior to always click on (0,0), in order to trigger the right context menu. This will fail if #attachmentList gets a border radius, but I think with the comment in place thats acceptable.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8395391 [details] [diff] [review]
Fix - v1

This doesn't seem to do it on Linux, taking back review until I can get a green try run.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: attlistclick.diff

I've gone through a few solutions and I think this is the best one. Looking at a few failed runs like:

http://clicky.visophyte.org/tools/arbpl-mozmill-standalone/?log=http://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/[e-mail]-c1927a0f809a/try-comm-central-linux/try-comm-central_ubuntu32_vm_test-mozmill-bm05-tests1-linux32-build1.txt.gz

It seems that the wrong element is targeted when doing the rightClick. Now I am not sure if mc.eid() gives me the wrong element, or if this is a bug in the older mozmill version we are using. Instead of spending ages debugging this I think we should rather use the DOM method of opening the popup. This works on all platforms with Lightning enabled as you can see in this try run:

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=cedcf097ac8d

The other failures are related to the current tree issues we are having.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8395611 [details] [diff] [review]
attlistclick.diff

Switching reviewers to better balance TB review queue sizes.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 8395611 [details] [diff] [review]
attlistclick.diff

Review of attachment 8395611 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! r=mkmelin

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v2

Patch for checkin, trees are still closed.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/e2fda9a870d6