Closed Bug 986960 Opened 8 years ago Closed 6 years ago
Intermittent erroring test, fullscreen
_image _test .js
46 bytes, text/x-github-pull-request
|Details | Review|
The following test is failing at a rate of about 3% since being re-enabled. As we can't afford to have intermittent failures creep up on us, I'm disabling the test for now. This one will probably be fairly tricky to debug, I would probably recommend using some screenshots to debug. Error details: the gallery ... ◦ should flick through images in fullscreen mode: No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself. The build has been terminated
Changed the component to Gaia::Gallery (the test concerns the gallery app)
Component: Gaia::Video → Gaia::Gallery
Comment on attachment 8620537 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/30527 This fix seems to consistently pass locally. Previously Save button was being pressed although there is no changes to the picture. (The latest behavior is that the save button will be greyed out unless there is a change to the file) Enabled auto-enhance to make the change. The older script also assumed that the app will exit to the thumbnail view after saving the picture, which is no longer the case. Let me know if I missed anything.
Attachment #8620537 - Flags: review?(pdahiya)
Thanks No-Jun for updating test as per the new flow and adding appropriate wait calls. Patch looks good and has my r+. One nit noted in github and with that patch looks good to land
Attachment #8620537 - Flags: review?(pdahiya) → review+
Thanks! Merged in Gaia: https://github.com/mozilla-b2g/gaia/commit/9f36b711af7597a6a32471c3305cf1e2d6947d39
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
You need to log in before you can comment on or make changes to this bug.