952706 - Gallery fullscreen image marionette orange

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Description

[Gareth Aye [:gaye] (back from PTO)]

1) the gallery should display an image fullscreen and go back:

AssertionError: false == true

at Context.<anonymous> (/home/travis/build/mozilla-b2g/gaia/apps/gallery/test/marionette/fullscreen_image_test.js:37:12)

at Test.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:211:32)

at Runner.runTest (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:372:10)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:448:12

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:297:14)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:307:7

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:245:23)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:269:7

at Hook.Runnable.run (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:213:5)

at next (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:257:10)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runner.js:269:7

at done (/home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:185:5)

at /home/travis/build/mozilla-b2g/gaia/node_modules/mocha/lib/runnable.js:197:9

at Object.executeHook (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:370:18)

at process._tickCallback (node.js:415:13)

Comment 1

[Punam Dahiya [:pdahiya]]

Attachment: Patch with the fix for Bug 952706 and Bug 943504

Hi Jim

Can you pl. review the attached gallery marionette tests. The PR fixes gallery marionette tests for
a) Swiping full screen images test
b) It updates Marionette tests to use marionette-file-manager API as reported in Bug 943504

Thanks

Comment 2

[Jim Porter (:squib)]

Looks good. I have some comments over on Github. r=me with those addressed. I'd actually give the r+ to the attachment, but Bugzilla breaks whenever I do that...

Comment 3

[Punam Dahiya [:pdahiya]]

Thanks Jim for review. I have addressed review comments in github and landed the pull request on master.

https://github.com/mozilla-b2g/gaia/commit/e3e6315f4527d743e963c94c160b9bae804649e4