987004 - [dolphin] FM radio doesn't work

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Vendcom, defect)

Description

[Kai-Zhen Li [:seinlin][:kli]]

FM radio doesn't work, and FM power status is alway isn off state.
---
I/FMRadio (  725): FMRadio is initialized.
E/GeckoConsole(  725): Content JS LOG at app://fm.gaiamobile.org/gaia_build_defer_index.js:166 in updatePowerUI: Power status: off
E/GeckoConsole(  725): Content JS LOG at app://fm.gaiamobile.org/gaia_build_defer_index.js:166 in updatePowerUI: Power status: off
E/GeckoConsole(  725): Content JS LOG at app://fm.gaiamobile.org/gaia_build_defer_index.js:166 in updatePowerUI: Power status: off

Comment 1

[Ivan Tsay (:ITsay)]

Based on comment 0, need partner to modify the FM driver for FM radio to work.

Comment 2

[Ivan Tsay (:ITsay)]

Hi James,

Mind if you can find someone on top of this POVB bug. Thanks.

Comment 3

[James Zhang (Spreadtrum)]

Loop Sam

Comment 4

[James Zhang (Spreadtrum)]

Add Ping Zhang,

   On latest dolphin version, FM can work now, but FM audio still can't work.

Ping and Jesse, please discuss here.

Comment 5

[Jesse]

Macro, our dolphin FM can't use audio system to adjust volume. We have discussed on our side, the only way to adjust the volume is FM driver.

We consider adding an api in Gonk to adjust the FM volume, like SetFMVolumeIndex/GetFMVolumeIndex.

What do you think?

Comment 6

[Kai-Zhen Li [:seinlin][:kli]]

Michael, there could be some technical limitation for FM radio on SPRD solution. For tarako we have the patch on v1.3t branch. But for v1.4 or master we still need to solve this kind of problem. 
Is it reasonable to have have a FM solution which allow to control vendor dependent part by compile flag or properties?

Comment 7

[Kai-Zhen Li [:seinlin][:kli]]

(In reply to Jesse from comment #5)
> Macro, our dolphin FM can't use audio system to adjust volume. We have
> discussed on our side, the only way to adjust the volume is FM driver.
> 
> We consider adding an api in Gonk to adjust the FM volume, like
> SetFMVolumeIndex/GetFMVolumeIndex.
> 
> What do you think?

Jesse, I think EnableFMAudio()/DisableFMAudio() can be moved and done setDeviceConnectionState. Then it is not necessary to patch gecko. Becuase I think audioManager->SetFmRadioAudioEnabled(aAudioEnabled) is followed by EnableFMAudio()/DisableFMAudio() is not a good idea. They should be done in hardware/libhardware_legacy/audio or frameworks/av/services/audioflinger/ accordingly.

Comment 8

[Kai-Zhen Li [:seinlin][:kli]]

Correction to comment 7.

I think EnableFMAudio()/DisableFMAudio() can be moved and done in setDeviceConnectionState.

Comment 9

[Jesse]

(In reply to Kai-Zhen Li from comment #8)
> Correction to comment 7.
> 
> I think EnableFMAudio()/DisableFMAudio() can be moved and done in
> setDeviceConnectionState.

It's not easy for media server to handle FM device fd opened in b2g process.

Comment 10

[Marco Chen [:mchen]]

I think :mwu is the right person on this FM module.

Comment 11

[sam.hua]

FM can work in the latest build.

Comment 12

[Jason Smith [:jsmith]]

Closing per comment 11.

Comment 13

[Kai-Zhen Li [:seinlin][:kli]]

Partner has fixed in these repos, need no more info.
system/core
hardware/libhardware_legacy

Comment 14

[sam.hua]

Hi Kaizhen,
It can work,but failed in adjust the volume,so could u reopen it?

Comment 15

[Kai-Zhen Li [:seinlin][:kli]]

Sam, I filed a new bug 1016803 to follow the FM volume issue.

Comment 16

[Kai-Zhen Li [:seinlin][:kli]]

Sorry for reopen this bug accidentally. Let's continue the FM volume issue on bug 1016803.