987091 - Multiple Sync calls makes a login fail with "Background fetch for key bundle failed: Error: A different user signed in"

Status: RESOLVED DUPLICATE of bug 982591

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Andrei Eftimie]

You will need to have bug 983642 to be able to run this.

It always fails in the same place. In other places the login works fine.
I initially thought this has something to do with `EnsureTracking` but it appears this is not the case.

Here is a log:
> CROSSWEAVE INFO: test phase 08: PASS
> System JS : WARNING resource://tps/modules/bookmarks.jsm:52 - mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create
> CROSSWEAVE INFO: Sync version: 1.33.0
> CROSSWEAVE INFO: Firefox builddate: 20140323030203
> CROSSWEAVE INFO: Firefox version: 31.0a1
> CROSSWEAVE INFO: Waiting for weave:service:ready...
> CROSSWEAVE INFO: weave:service:ready observed!
> CROSSWEAVE INFO: Starting phase 9/16
> CROSSWEAVE INFO: setting client.name to profile1
> CROSSWEAVE INFO: ----------event observed: sessionstore-windows-restored
> CROSSWEAVE INFO: starting action: EnsureTracking
> CROSSWEAVE INFO: Setting client credentials and login.
> CROSSWEAVE INFO: Login via Firefox Accounts.
> CROSSWEAVE INFO: ----------event observed: fxaccounts:onlogin
> CROSSWEAVE INFO: Waiting for weave:service:setup-complete...
> 1395664687159	Sync.BrowserIDManager	ERROR	fxa.getAssertion() failed with: undefined - A different user signed in
> 1395664687159	Sync.BrowserIDManager	ERROR	Non-authentication error in _fetchTokenForUser: A different user signed in
> 1395664687162	Sync.BrowserIDManager	ERROR	Background fetch for key bundle failed: Error: A different user signed in
> CROSSWEAVE INFO: ----------event observed: weave:service:setup-complete
> CROSSWEAVE INFO: ----------event observed: weave:engine:start-tracking
> CROSSWEAVE INFO: weave:service:setup-complete observed!
> CROSSWEAVE INFO: ----------event observed: weave:service:sync:finish
> CROSSWEAVE ERROR: [phase09] Exception caught: ASSERTION FAILED! Weave status OK; expected "success.status_ok", got "error.login.failed" No traceback available
> 
> TEST-UNEXPECTED-FAIL | test_addon_nonrestartless_xpi.js | [phase09] Exception caught: ASSERTION FAILED! Weave status OK; expected "success.status_ok", got "error.login.failed" No traceback available

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

What is phase 9 doing? A reference to the test would be good.

Comment 2

[Andrei Eftimie]

Attachment: 987091_testcase.js

Here's a simple testcase attached.
It fails every time.

It seems the problem has to do with multiple sync calls.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As Andrei said it doesn't fail when calling `Sync` multiple times in the same phase. So it may be related to a phase which is using a profile where the user has not been logged in, while a login happened with an initial profile. But then other tests also would fail. Would be good to know if the testcase can even further be minimized.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Andrei, do you still see this issue? I don't with a latest inbound  build. I assume my patch on bug 982591 fixed that. If that is the case please dupe, given that this is the same underlying issue with hard-coded keys.

Comment 5

[Andrei Eftimie]

Awesome work Henrik, indeed both the testcase and the initial failure in test_addon_nonrestartless_xpi.js are now gone.