987133 - Unxfail and fix test_cards_view_with_two_apps.py

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Robert Chira [:RobertC]]

Unxfailign test_cards_view_with_two_apps.py because Bug 946130 was fixed.
Also fixed the test since it was failing from an unrelated issue.

Comment 1

[Robert Chira [:RobertC]]

Attachment: Pull request

Comment 2

[Zac C (:zac)]

Comment on attachment 8395685 [details] [review]
Pull request

Well done for spotting that this can be fixed but we need to make this change against master and then uplift it to v1.4 instead.

Comment 3

[Robert Chira [:RobertC]]

Attachment: Pull request 2

Added a new pull request for master branch.

Comment 4

[Viorela Ioia [:viorela]]

Comment on attachment 8396200 [details] [review]
Pull request 2

Beside comments in the PR, the test runs nice :)

Comment 5

[Zac C (:zac)]

Comment on attachment 8396200 [details] [review]
Pull request 2

r+

Comment 6

[Zac C (:zac)]

Master
https://github.com/mozilla-b2g/gaia/commit/70ae5e13ec5dc13ec423abe1937397ffe50b518d

v1.4
https://github.com/mozilla-b2g/gaia/commit/7e705dd4718d528974d99ac31866318d7e201152

Comment 7

[Kevin Grandon :kgrandon]

Landing this caused it to fail in 1.4 test_cards_view_with_two_apps.py test_cards_view_with_two_apps.TestCardsView.test_that_app_can_be_launched_from_cards_view =/

Error stack: TEST-START test_cards_view_with_two_apps.py

test_that_app_can_be_launched_from_cards_view (test_cards_view_with_two_apps.TestCardsView)

https://moztrap.mozilla.org/manage/case/2462/ ... ERROR

======================================================================

ERROR: None

----------------------------------------------------------------------

Traceback (most recent call last):

File "/home/travis/build/mozilla-b2g/gaia/travis_venv/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/marionette_test.py", line 163, in run

testMethod()

File "/home/travis/build/mozilla-b2g/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/cards_view/test_cards_view_with_two_apps.py", line 38, in test_that_app_can_be_launched_from_cards_view

cards_view.tap_app(self._test_apps[0])

File "/home/travis/build/mozilla-b2g/gaia/tests/python/gaia-ui-tests/gaiatest/apps/system/regions/cards_view.py", line 41, in tap_app

self.wait_for_condition(lambda m: card_view.value_of_css_property('pointer-events') == 'auto')

File "/home/travis/build/mozilla-b2g/gaia/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 54, in wait_for_condition

Wait(self.marionette, timeout).until(method, message=message)

File "/home/travis/build/mozilla-b2g/gaia/travis_venv/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/wait.py", line 143, in until

cause=last_exc)

TimeoutException: TimeoutException: Timed out after 10.0385260582 seconds

TEST-UNEXPECTED-FAIL | test_cards_view_with_two_apps.py test_cards_view_with_two_apps.TestCardsView.test_that_app_can_be_launched_from_cards_view |

----------------------------------------------------------------------

Ran 1 test in 20.640s



Reverted master: https://github.com/mozilla-b2g/gaia/commit/9da1b9c11bf518bce882be305ae121c44c5d1e05
Reverted v1.4: https://github.com/mozilla-b2g/gaia/commit/8838052fc451a2a9579fa22a353fbaeb42dd13bb

Comment 8

[Robert Chira [:RobertC]]

I checked the changes against v1.4 branch and could not reproduce the failure. Also started an adhoc run
http://selenium.qa.mtv2.mozilla.com:8080/view/B2G%20Hamachi/job/b2g.hamachi.mozilla-aurora.ui.adhoc/21/HTML_Report/?

Did this issue reproduce 100% or intermittently? On the device did the card change to calendar after the flick() action?

Comment 9

[Kevin Grandon :kgrandon]

This was an intermittent test that happened on travis as soon as the patch landed. I'm not sure what state it got to - I only have the above dump.

You may want to test a few runs on travis to see what if anything is different.

Comment 10

[Zac C (:zac)]

Robert you need to test this for intermittents on Travis/desktopb2g. It behaves differently to the device.

Comment 11

[Robert Chira [:RobertC]]

Attachment: Pull request 2

The failure from Travis is caused by the flick action not working. It seems that the the test moves too fast from opening the cards view to the flick action. I added a PR with a time.sleep before flick().

Instead of the sleep I tried waiting for the cards view by using different locators, but nothing seems to work, it was still failing with the same error.

Comment 12

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8397738 [details] [review]
Pull request 2

A few comments:

* We should strive to avoid sleeps. We could ask the gaia devs if there's something specific we could wait for, or perhaps they can add something for us to improve testability. Also, try comparing the page source before and after the event to see if there's anything that jumps out.

* If we have to resort to a sleep (it really is a last resort) then we shouldn't also include a wait that doesn't achieve anything.

* Why are we returning element.tap() in tap_app? This wasn't introduced by your patch, but you modify that line and we should clean that up.

* It's not obvious to me why you're changing it from switching to the next app to the previous app.

Comment 13

[Zac C (:zac)]

+1, the location of the sleep you are using suggests that the wait prior to that is insufficient so try and refine that one.

I think the team must have reversed the index order of the cards in the view. This test has been disabled for a long time because of the Marionette issue so we would not have noticed it.

Comment 14

[Zac C (:zac)]

This has been invalidated by being blocked by bug 946130.

Comment 15

[[:AndreiH]]

I know this was reverted because it was failing on travis, but it is still flicking in the wrong direction

Comment 16

[Zac C (:zac)]

(In reply to [:AndreiH] from comment #15)
> I know this was reverted because it was failing on travis, but it is still
> flicking in the wrong direction

Can you file a separate bug to resolve it?

Comment 17

[[:AndreiH]]

sure, i'll open another bug and take a look