Closed
Bug 987252
Opened 11 years ago
Closed 11 years ago
Loop desktop client should display proper error notifications to end user
Categories
(Hello (Loop) :: Client, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla33
People
(Reporter: NiKo, Unassigned)
References
Details
(Whiteboard: s=mlpnightly3)
Attachments
(1 file)
We could reuse the Backbone views & model from the Desktop client, ensuring we move shared bits to the shared folder.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → nperriault
|
||
Updated•11 years ago
|
|
|
||
Updated•11 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 1•11 years ago
|
||
This patch make the conversation & panel scripts to reuses the shared notification system introduced in the Loop client through https://github.com/mozilla/loop-client/pull/11 (not landed yet, pending review)
Attachment #8401219 -
Flags: review?(standard8)
|
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8401219 [details] [review]
https://github.com/adamroach/gecko-dev/pull/11
Generally good, I'd just like to look at the L10n changes that I commented on in the PR before this lands.
Attachment #8401219 -
Flags: review?(standard8)
Attachment #8401219 -
Flags: review-
Attachment #8401219 -
Flags: feedback+
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8401219 [details] [review]
https://github.com/adamroach/gecko-dev/pull/11
Updated changes look good. r=Standard8
Attachment #8401219 -
Flags: review- → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Whiteboard: s=mlpnightly3
|
|
||
Comment 5•11 years ago
|
||
|
|
||
Comment 6•10 years ago
|
||
|
|
||
Updated•10 years ago
|
Target Milestone: --- → mozilla33
|
||
Comment 7•10 years ago
|
||
Please use meaningful string ids in the future.
Looks like this landed with tests. Does this need QA testing?
QA Contact: anthony.s.hughes
Whiteboard: s=mlpnightly3 → s=mlpnightly3 [qa?]
Hi Niko, does this need QE verification? If so, please advise.
Flags: qe-verify?
Flags: needinfo?(nperriault)
Whiteboard: s=mlpnightly3 [qa?] → s=mlpnightly3
|
|
Assignee | |
Comment 10•10 years ago
|
||
Notifications have been refactored a lot since this patch has initially landed, and is about to be redone again. While we probably want smoketests for notifications, I don't think this would be the appropriate bug anyway.
Flags: needinfo?(nperriault)
You need to log in
before you can comment on or make changes to this bug.
Description
•