Closed Bug 987252 Opened 10 years ago Closed 10 years ago

Loop desktop client should display proper error notifications to end user


(Hello (Loop) :: Client, defect, P3)



(Not tracked)



(Reporter: NiKo, Unassigned)



(Whiteboard: s=mlpnightly3)


(1 file)

We could reuse the Backbone views & model from the Desktop client, ensuring we move shared bits to the shared folder.
Assignee: nobody → nperriault
Blocks: 974875
No longer blocks: 979880
Summary: Loop webapp should display proper error notifications to end user → Loop desktop client should display proper error notifications to end user
Priority: -- → P3
This patch make the conversation & panel scripts to reuses the shared notification system introduced in the Loop client through (not landed yet, pending review)
Attachment #8401219 - Flags: review?(standard8)
Comment on attachment 8401219 [details] [review]

Generally good, I'd just like to look at the L10n changes that I commented on in the PR before this lands.
Attachment #8401219 - Flags: review?(standard8)
Attachment #8401219 - Flags: review-
Attachment #8401219 - Flags: feedback+
Comment on attachment 8401219 [details] [review]

Updated changes look good. r=Standard8
Attachment #8401219 - Flags: review- → review+
Whiteboard: s=mlpnightly3
Target Milestone: --- → mozilla33
Please use meaningful string ids in the future.
Looks like this landed with tests. Does this need QA testing?
QA Contact:
Whiteboard: s=mlpnightly3 → s=mlpnightly3 [qa?]
Hi Niko, does this need QE verification? If so, please advise.
Flags: qe-verify?
Flags: needinfo?(nperriault)
Whiteboard: s=mlpnightly3 [qa?] → s=mlpnightly3
Notifications have been refactored a lot since this patch has initially landed, and is about to be redone again. While we probably want smoketests for notifications, I don't think this would be the appropriate bug anyway.
Flags: needinfo?(nperriault)
Thanks Niko.
Flags: qe-verify? → qe-verify-
You need to log in before you can comment on or make changes to this bug.