We could reuse the Backbone views & model from the Desktop client, ensuring we move shared bits to the shared folder.
5 years ago
5 years ago
Assignee: nobody → nperriault
Created attachment 8401219 [details] [review] https://github.com/adamroach/gecko-dev/pull/11 This patch make the conversation & panel scripts to reuses the shared notification system introduced in the Loop client through https://github.com/mozilla/loop-client/pull/11 (not landed yet, pending review)
Comment on attachment 8401219 [details] [review] https://github.com/adamroach/gecko-dev/pull/11 Generally good, I'd just like to look at the L10n changes that I commented on in the PR before this lands.
Comment on attachment 8401219 [details] [review] https://github.com/adamroach/gecko-dev/pull/11 Updated changes look good. r=Standard8
Attachment #8401219 - Flags: review- → review+
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Please use meaningful string ids in the future.
Looks like this landed with tests. Does this need QA testing?
QA Contact: anthony.s.hughes
Whiteboard: s=mlpnightly3 → s=mlpnightly3 [qa?]
Hi Niko, does this need QE verification? If so, please advise.
Whiteboard: s=mlpnightly3 [qa?] → s=mlpnightly3
Notifications have been refactored a lot since this patch has initially landed, and is about to be redone again. While we probably want smoketests for notifications, I don't think this would be the appropriate bug anyway.
Flags: qe-verify? → qe-verify-
You need to log in before you can comment on or make changes to this bug.