Develop Minimal UI for Link Clickers to initiate call

VERIFIED FIXED in mozilla33

Status

defect
P1
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Unassigned)

Tracking

unspecified
mozilla33
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [est: 4d][qa+])

User Story

When I click a link supplied by loop, a tab opens that enables me to start a call.

Approximate UX & flow:

- Client Tab is opening, with url such as https://<server>/call/<token>
- Client POSTs to loop server with /call/<token>
-- Client receives API keys & session id
- Client requests Video permissions (aka initiates joining the call in the sdk)
- On successful permission grant, appropriate media UX is displayed
- When remote user accepts, the remote video is displayed

Notes:

- No audio-only, no face mute, no remote audio mute

Attachments

(4 attachments)

Comment hidden (empty)
(Reporter)

Updated

5 years ago
User Story: (updated)
(Reporter)

Updated

5 years ago
User Story: (updated)
Whiteboard: [needs Tokbox stub/permission to land][need to understand server flow models]
(Reporter)

Comment 1

5 years ago
We need to understand the server flow models here, as I don't think the currently published API meets what the UX was thinking.
(Reporter)

Updated

5 years ago
Assignee: nobody → standard8
(Reporter)

Updated

5 years ago
User Story: (updated)
Priority: -- → P1
Whiteboard: [needs Tokbox stub/permission to land][need to understand server flow models] → [est: 4d][needs Tokbox stub/permission to land][need to understand server flow models]
(Reporter)

Updated

5 years ago
Assignee: standard8 → nperriault
User Story: (updated)
Whiteboard: [est: 4d][needs Tokbox stub/permission to land][need to understand server flow models] → [est: 4d]
This is a first step in the process of creating a basic set of views and having a mechanism to map backbone routes (urls) to a single active view.
Attachment #8394022 - Flags: review?(standard8)
Attachment #8394022 - Flags: feedback?(dmose)
Comment on attachment 8394022 [details] [review]
https://github.com/mozilla/loop-client/pull/2

As dmose and Standard8 are both on PTO today and we need to get this landed asap, I'm assigning ametaireau as a reviewer.
Attachment #8394022 - Flags: review?(standard8) → review?(alexis+bugs)
While I consider the current patch to be valid, I'm not sure it solves the scenario described in this bug.

Especially, it's not doing any requests to the server or storing API keys / sessions / tokens, nor displaying anything to the user.

I suggest that we either create a set of bugs blocking this one or that we update the description of this bug because we consider it should only do the "minimal UI".
Attachment #8394022 - Flags: review?(alexis+bugs) → review+
Sure, as the patch description says:

> This is a first step in the process of creating a basic set of views and having a mechanism to map backbone routes (urls) to a single active view.

More patches will follow soon.
Another step towards full resolution of bug. I think it's easier to have small patches to review instead of a huge one; this also eases getting feedback early.
Attachment #8395551 - Flags: review?(standard8)
(Reporter)

Comment 8

5 years ago
Comment on attachment 8395551 [details] [review]
https://github.com/mozilla/loop-client/pull/3

Please squash the commits into one, and add r=Standard8 to the commit message.

Looks good, r=Standard8
Attachment #8395551 - Flags: review?(standard8) → review+
Landed PR 4 https://github.com/mozilla/loop-client/commit/050a39eebecd26c88efd1d1326d4bf221043c0e8

Bug remains open for call establishment, which is to be addressed by a following PR.
New PR for the establishing the call using partner's SDK.
Attachment #8396512 - Flags: review?(dmose)
Attachment #8396512 - Flags: feedback?(standard8)
Comment on attachment 8394022 [details] [review]
https://github.com/mozilla/loop-client/pull/2

post-facto r=dmose on PR 2
Attachment #8394022 - Flags: review+
Attachment #8394022 - Flags: feedback?(dmose)
Attachment #8394022 - Flags: feedback+
Comment on attachment 8396512 [details] [review]
https://github.com/mozilla/loop-client/pull/4

Looks good; r=dmose with the comments in the PR either addressed, or explanations of why they don't need to be addressed immediately.
Attachment #8396512 - Flags: review?(dmose) → review+
(Reporter)

Comment 14

5 years ago
Comment on attachment 8396512 [details] [review]
https://github.com/mozilla/loop-client/pull/4

Dan's comments here are enough.
Attachment #8396512 - Flags: feedback?(standard8)
Attempt at fixing Partner SDK styles.
Attachment #8397117 - Flags: review?(standard8)
Comment on attachment 8397117 [details] [review]
https://github.com/mozilla/loop-client/pull/5

Did a f2f review; r=dmose with the tweaks that you've already made at my request, and dropping the readme.html changes and putting them in a separate PR.
Attachment #8397117 - Flags: review?(standard8) → review+
(Reporter)

Comment 18

5 years ago
I believe this is complete now -> Fixed.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Updated

5 years ago
No longer depends on: 988229
(Reporter)

Updated

5 years ago
No longer depends on: 987252
(Reporter)

Updated

5 years ago
Group: mozilla-employee-confidential
(Reporter)

Updated

5 years ago
Target Milestone: --- → mozilla33
Verified fixed in Firefox 33 and 34.
Status: RESOLVED → VERIFIED
QA Contact: anthony.s.hughes
Whiteboard: [est: 4d] → [est: 4d][qa+]
You need to log in before you can comment on or make changes to this bug.