987328 - Notes are not sorted right in RNA release-notes pages

Status: RESOLVED FIXED

(www.mozilla.org :: Bedrock, defect)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

From :lsblakk: "notes are not respecting sort num where the Mixed content note has a sort number of 1000 and then options panel is a -50 (ie: they are reversed in the /b version)"

Here are the notes in question:

Mixed Content: https://nucleus.mozilla.org/admin/rna/note/785360/
Options panel: https://nucleus.mozilla.org/admin/rna/note/327/

Options panel sorts higher in the section and should sort at the very bottom of the section.

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

To extend the sort issue here's the logic we've used:

For notes that are added to a dot release - ie: have a version number starting off the content of a note, like https://nucleus.mozilla.org/admin/rna/note/413 we need those notes (even though they are tagged "FIXED") to be at the very top of the release notes no matter what.  I believe we discussed adding a new tag to deal with these like "DOT FIXED" or something so that the logic driving the templates would know to a) put them at the top and b) still use the "FIXED" tag style for that note.

For regular notes, they should get sorted within their tag group from highest sort number to lowest.  That's why some will have 1000 (or even higher) and others will have negative numbers as the sort order number (to keep them at the very bottom).

We don't have to use negative numbers going forward, if that breaks things, and someday a nice enhancement would be drag n drop sorting in the web interface. In the meantime we just need to (for press & PR reasons) put certain notes higher than others.

Comment 2

[Josh Mize [:jgmize]]

Attachment: rna pr 29

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/rna

https://github.com/mozilla/rna/commit/32a371ac55bd0d5bb9703761b53d072a9252b366
Improve note sorting for bug 987328

https://github.com/mozilla/rna/commit/b84754b3b3caa8987fc58c88667127605ed79193
Merge pull request #29 from jgmize/improve-note-sort

Improve note sorting for bug 987328

Comment 4

[Josh Mize [:jgmize]]

Attachment: bedrock PR 1827

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/57ea1c7332a0e9dfa77cd59b1f07bb44227097e8
Update rna submodule to fix bug 987328

https://github.com/mozilla/bedrock/commit/699f7f8dc02fde5783c90cb2084df42e912978b0
Merge pull request #1827 from jgmize/improve-note-sort

Update rna submodule to fix bug 987328

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8396145 [details] [review]
rna pr 29

as mentioned on GH - this looks good in action - thanks!