987403 - Enable gzip on commonplace index.html

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Comment 1

[Christopher Van Wiemeersch [:cvan]]

We could get a 66% reduction in document size.

Comment 2

[Dethe Elza [:dethe]]

Wouldn't we want to enable gzip everywhere? Or at least on all text documents (HTML, CSS, JavaScript)?

I'm assuming this would be an nginx configuration that would go in here: https://github.com/mozilla-services/svcops-puppet/blob/master/modules/marketplace/templates/nginx/marketplace.conf#L184

Comment 3

[Christopher Van Wiemeersch [:cvan]]

(In reply to Dethe Elza [:dethe] from comment #2)
> Wouldn't we want to enable gzip everywhere? Or at least on all text
> documents (HTML, CSS, JavaScript)?
> 
> I'm assuming this would be an nginx configuration that would go in here:
> https://github.com/mozilla-services/svcops-puppet/blob/master/modules/
> marketplace/templates/nginx/marketplace.conf#L184

We are already gzipping all text (CSS, JavaScript, JSON) on the CDN on prod:

%% curl 'https://marketplace.cdn.mozilla.net/media/fireplace/css/include.css?b=1396521250112' -H 'Accept-Encoding: gzip,deflate,sdch' -I                                                                           
HTTP/1.1 200 OK
...
Content-Encoding: gzip
...

And on the CDN on -dev:

%% curl 'https://marketplace-dev.mozflare.net/media/fireplace/css/include.css?b=1396522545259' -H 'Accept-Encoding: gzip,deflate,sdch' -I
HTTP/1.1 200 OK
...
Content-Encoding: gzip

On -dev, previously assets were being served from Zamboni, not the CDN, so yeah modifying the nginx conf file for -dev would be great for that. I had asked Jason to do it a while back, so yeah a pull request for that would be great.

Comment 4

[Mathieu Pillard [:mat]]

https://github.com/mozilla/zamboni/pull/2576

Note that we don't enable gzip on other HTML documents deliberately, because of BREACH [0]. However, commonplace pages are not supposed to contain secrets, so we can enable gzip here.

[0] http://breachattack.com/

Comment 5

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/5c561ef2973aeb335e07c1048b8e4cc73cf93a5b

STR:
- Load https://marketplace-dev.allizom.org/ in your browser with developer tools network opened (HTML tab).
- Check that 'Content-Encoding: "gzip"' is present in the response headers for the "/" page.
- Check that the page displays normally.
- Check that 'Content-Encoding: "gzip"' is also present in the response headers for the "iframe-install.html" page.

Note: clear your browser cache beforehand or Ctrl+Shift+R if you don't see the requests.

Comment 6

[Madalin Cotetiu]

Verified as fixed in FF35(Win7) in marketplace-dev.alliom.org
Postfix screencast: http://screencast.com/t/4YrkL0vqOqJp
Closing.