987417 - Update copy in fxa settings app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: FxA, defect)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Update strings to match spec uploaded in bug 960130.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Github PR 17611

Comment 2

[Francesco Lodolo [:flod]]

Sorry but you can't do this on landed strings: changed string, new ID. 

And that's the main reason why copy should happen *before* code landing, for everyone's sanity.

This comment is valid for all three bugs.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8396831 [details] [review]
Github PR 17611

As Francesco suggested, please use a new string ID if the string is changed.

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 8396831 [details] [review]
Github PR 17611

l10n keys added, resubmitting.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8396831 [details] [review]
Github PR 17611

r=me. Please squash the commits before merging, thanks.

Comment 6

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Awesome, thanks Arthur.

Pushing to Try before asking for checkin, because TravisCI is a known liar

https://tbpl.mozilla.org/?tree=Try&rev=66101b2e4fbe

Comment 7

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Well, that was weird output. Try-ing again:

https://tbpl.mozilla.org/?tree=Try&rev=2da377e1d764

Comment 8

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Well, it happened again!

* Try is freaking out (2x now)
* Travis is happy
* Tests run locally without any trouble

Thoughts?

Comment 9

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

hmm. let's just push to Try once more and see what happens:

https://tbpl.mozilla.org/?tree=Try&rev=4b5ad5564457

Comment 10

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Nope. Looks like the Try behavior is something deeper, it's being discussed in bug 989159.

I'll mark this checkin-needed whenever the tree reopens.

Comment 11

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

OK, the tree is reopened, the patch is rebased against today's master, and Travis is green.

Merging.