987419 - Update copy in fxa panel within FTE

Status: RESOLVED FIXED

(Firefox OS Graveyard :: FxA, defect)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Per spec uploaded in bug 960130, the copy should read:

"Use your email address to create an account or sign in."

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Whoops, my description was incorrect. see the pull request for the actual phrase changed :-P

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Github PR 17612

Comment 3

[Francesco Lodolo [:flod]]

Sorry for reiterating the comment over 3 bugs, but I want to be sure reviewers see it.
https://developer.mozilla.org/en-US/docs/Making_String_Changes

This rule applies to Gaia as well.

So, please, get the copy checked before landing code.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8396835 [details] [review]
Github PR 17612

As commented before, there are some rules for string changing.

If I'm not wrong, you should name your string <string>2 or <string>3, depending the times the string changed.

That will help translators to know what's going on with that specific string and that they have to change it.

Thanks!
F.

Comment 5

[Axel Hecht [:Pike]]

PS: the suffix number is a hack if you're not having a good new name. In general, the strings should have names as if they were variables, with good semantic meaning.

Which, if the semantics of a string change, often suggests the new name.

In this case of just broken copy, doesn't help us much.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Axel Hecht [:Pike] from comment #5)
> PS: the suffix number is a hack if you're not having a good new name. In
> general, the strings should have names as if they were variables, with good
> semantic meaning.
> 
> Which, if the semantics of a string change, often suggests the new name.
> 
> In this case of just broken copy, doesn't help us much.

Thanks for the clarification Axel!

Comment 7

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

:flod I don't understand what exactly is so different about the string here.

What would you suggest I change the tag to? fxa-intro2?

Comment 8

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

ah wait, I get it! anything different, even a synonym (I looked more closely at the l10n git history).

Comment 9

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Github PR 17675

I typo'd the bug number in the first PR, reopened to fix that.

Also addressed the review feedback

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8397455 [details] [review]
Github PR 17675

Thanks Jared!

Could you squash the commits into one and merge?

Comment 11

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Squashed, Travis is happy, merging.

Comment 12

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Master: https://github.com/mozilla-b2g/gaia/commit/b7a304a173a0b7e0fdd201efb788b20c5bea0267