Closed Bug 987522 Opened 6 years ago Closed 6 years ago

Improve localizability of translation infobar

Categories

(Firefox :: Translation, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 31

People

(Reporter: flod, Assigned: florian)

References

Details

(Whiteboard: [translation] p=1 s=it-31c-30a-29b.2 [qa-])

Attachments

(1 file, 1 obsolete file)

Follow-up from bug 979424.

https://bug979424.bugzilla.mozilla.org/attachment.cgi?id=8393507

Case 1 and 3: I think it would be safer to have a third string, empty for en-US, to be displayed after the last listbox. Ideal situation would be to have a string with placeholders, but I don't think it's feasible in this context.

Also need l10n notes across the file explaining what's going to happen with those strings, and the fact that language names are taken from another file and could not be in the correct grammar case.

The alternative would be to have language names in this file, but I don't see that scaling (e.g. we couldn't add a language after version X has moved to Aurora).
Attached patch Patch (obsolete) — Splinter Review
(In reply to Francesco Lodolo [:flod] from comment #0)

> Case 1 and 3: I think it would be safer to have a third string, empty for
> en-US, to be displayed after the last listbox.

In case 1 there's already a localizable string on both sides of the drop down.
The attached patch adds a third string after the second drop down for case 3.

> Also need l10n notes across the file explaining what's going to happen with
> those strings, and the fact that language names are taken from another file
> and could not be in the correct grammar case.

Added. Let me know if this is clear enough.
Attachment #8396543 - Flags: feedback?(francesco.lodolo)
(In reply to Florian Quèze [:florian] [:flo] from comment #1)
> In case 1 there's already a localizable string on both sides of the drop
> down.

Yes, but at least from the image it seems visually separated from the original one.
Comment on attachment 8396543 [details] [diff] [review]
Patch

Review of attachment 8396543 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. A small note, but overall localization comments look good.

::: browser/locales/en-US/chrome/browser/translation.dtd
@@ +9,5 @@
> +  -  In en-US it looks like this:
> +  -    This page is in [detected language] Translate this page?
> +  -  "detected language" here is a language name coming from the
> +  -  global/languageNames.properties file; for some locales it may not be in
> +  -  the correct grammar case to construct a sentence. -->

I would say "in the correct grammar case to keep the same structure of the original sentence".

@@ +26,5 @@
> +  -  In en-US it looks like this:
> +  -    This page has been translated from [from language] to [to language]
> +  -  "from language" and "to language" here are language names coming from the
> +  -  global/languageNames.properties file; for some locales they may not be in
> +  -  the correct grammar case to construct a sentence.

Same here.
Attachment #8396543 - Flags: feedback?(francesco.lodolo) → feedback+
(In reply to Francesco Lodolo [:flod] from comment #2)
> (In reply to Florian Quèze [:florian] [:flo] from comment #1)
> > In case 1 there's already a localizable string on both sides of the drop
> > down.
> 
> Yes, but at least from the image it seems visually separated from the
> original one.

The image is a UX mockup. Here are screenshots of the actual implementation: http://minus.com/mn4dveUymZzfB
Attached patch Patch v2Splinter Review
Addressed comment 3.
Assignee: nobody → florian
Attachment #8396543 - Attachment is obsolete: true
Attachment #8396576 - Flags: review?(felipc)
(In reply to Florian Quèze [:florian] [:flo] from comment #4)
> The image is a UX mockup. Here are screenshots of the actual implementation:
> http://minus.com/mn4dveUymZzfB

OK, makes definitely sense like this.
Attachment #8396576 - Flags: review?(felipc) → review+
Hi Florian, Gavin informed us this bug is to be added to the current iteration.  Please provide a point value now that it has been added.  Thanks.
Status: NEW → ASSIGNED
Flags: needinfo?(florian)
Whiteboard: [translation] p=0 s=it-31c-30a-29b.1
Hi Anthony, can you review if this bug should be [qa+] or [qa-] for verification.
Flags: needinfo?(anthony.s.hughes)
(In reply to Marco Mucci [:MarcoM] from comment #7)
> Hi Florian, Gavin informed us this bug is to be added to the current
> iteration.  Please provide a point value now that it has been added.  Thanks.

Easy/1.
Flags: needinfo?(florian)
Whiteboard: [translation] p=0 s=it-31c-30a-29b.1 → [translation] p=1 s=it-31c-30a-29b.1
qa+ to test with some of our top locales. Note that not *all* locales will be tested. There are just too many to test in time. I would suggest we find some way to inform localizers of this work and get their support in dogfooding the feature.
Flags: needinfo?(anthony.s.hughes)
QA Contact: bogdan.maris
Whiteboard: [translation] p=1 s=it-31c-30a-29b.1 → [translation] p=1 s=it-31c-30a-29b.1 [qa+]
Whiteboard: [translation] p=1 s=it-31c-30a-29b.1 [qa+] → [translation] p=1 s=it-31c-30a-29b.2 [qa+]
https://hg.mozilla.org/mozilla-central/rev/831be8bf62d3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
< flo-retina: I'm not sure there's much to verify in that bug; we mostly added comments to ensure localizers aren't confused
As discussed on IRC with Florian I think we should mark this [qa-] for now and wait for localizers to test this when the feature will arrive in nightly. If there is anything I can help with here please let me know.
Whiteboard: [translation] p=1 s=it-31c-30a-29b.2 [qa+] → [translation] p=1 s=it-31c-30a-29b.2 [qa-]
Status: RESOLVED → VERIFIED
No longer blocks: fxdesktopbacklog
Flags: firefox-backlog+
Mass move of translation bugs to the new Translation component.
Component: General → Translation
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.