987533 - [keyboard refactor] breakdown MockEventTarget, MockInputMethod, and MockInputContext from input_field_test.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

Follow-up bug of bug 977452
 
We may need to breakdown MockEventTarget, MockInputMethod, and MockInputContext from input_field_test.js.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Taking, and I will implement this bug by converting MockDOMRequest.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

WIP: https://github.com/timdream/gaia/tree/mock-event-target

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Pull request updated with all the mocks, I am now converting the input_field.js tests.

Comment 4

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#17709

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8397833 [details] [review]
mozilla-b2g:master PR#17709

Jan, could you review the input_method_test.js?
Alive, could you review the mocks?

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8397833 [details] [review]
mozilla-b2g:master PR#17709

r+ for mock-event-target part.

Comment 7

[Jan Jongboom [:janjongboom] (inactive)]

Comment on attachment 8397833 [details] [review]
mozilla-b2g:master PR#17709

I don't think we're actually testing anything here at the moment. Yeah, if properties are copied correct from a mocked object. But that's all there is, and I doubt if that required a 500 line test file to be honest.

I would rather like to test this against the real mozInputMethod as I don't think these tests will ever catch a regression or make more to the point tests.

Leaving r? open for now to get some feedback :-)

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The purpose of input_field_test.js is to test the input_field.js. If you want to test the API part we would need to write integration tests.

That said, we do need to verify the mock is indeed interact with InputField in the correct sequence. It would be worthy of to figure out we have enough mochitests for API in Gecko too.

Comment 9

[Jan Jongboom [:janjongboom] (inactive)]

All the tests assume that promises will always resolve positively; but that's not the case (e.g. keypress gets preventDefaulted). Are we covering this in a follow up issue in the end?

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Jan Jongboom [:janjongboom] from comment #9)
> All the tests assume that promises will always resolve positively; but
> that's not the case (e.g. keypress gets preventDefaulted). Are we covering
> this in a follow up issue in the end?

Right, I filed bug 994583.

Comment 11

[Jan Jongboom [:janjongboom] (inactive)]

Comment on attachment 8397833 [details] [review]
mozilla-b2g:master PR#17709

r=me.

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/6cfe96ba5c2be43688c1493364fa08f1904eef99