Closed Bug 987753 Opened 6 years ago Closed 6 years ago

Land a vertical homescreen in test_apps

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

defect
Not set

Tracking

(b2g-v2.0 fixed)

RESOLVED FIXED
1.4 S6 (25apr)
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Whiteboard: [c= p=4 s= u=], [systemsfe])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
vingtetun
: review+
Details | Review
We have a simple vertical homescreen prototype, we should land it in test_apps.
Attached file Github pull request
Comment on attachment 8396505 [details] [review]
Github pull request

Hey Vivien - would you have time to review this one? Thanks!
Attachment #8396505 - Flags: review?(21)
Blocks: 988401
Comment on attachment 8396505 [details] [review]
Github pull request

I'm going to re-review it once bug 899994 is fixed. It would be awesome to start from a privileged only homescreen and on the road fix the issues that prevent third party homescreens.
Attachment #8396505 - Flags: review?(21)
(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #3)
> Comment on attachment 8396505 [details] [review]
> Github pull request
> 
> I'm going to re-review it once bug 899994 is fixed. It would be awesome to
> start from a privileged only homescreen and on the road fix the issues that
> prevent third party homescreens.

UX wants to do user testing in 2 weeks so I don't think we can block on bug 899994.
This would put the whole homescreen 2.0 at risk :(
One way forward might be to use a branch for now. Alternatively there will be a bug that "turns on" homescreen 2 by default, and we can block that bug on tasks to make it a privileged app.
Blocks: vertical-homescreen
No longer blocks: 988401
Comment on attachment 8396505 [details] [review]
Github pull request

Let's add a stamp to land that on test_apps. However if that code goes into production at some point it will need a deeper review.
Attachment #8396505 - Flags: review+
Landed with the understanding that we will be doing a much deeper review when it comes time to move this into the apps/ folder.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Depends on: 1000305
Depends on: 1000313
Depends on: 1000315
Whiteboard: [c= p=4 s= u=] → [c= p=4 s= u=], [systemsfe]
Target Milestone: --- → 1.4 S5 (11apr)
Target Milestone: 1.4 S5 (11apr) → 1.4 S6 (25apr)
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
Depends on: 1042797
No longer depends on: 1042797
Depends on: 1042807
No longer depends on: 1042807
Depends on: 1092726
You need to log in before you can comment on or make changes to this bug.