Closed
Bug 987753
Opened 10 years ago
Closed 10 years ago
Land a vertical homescreen in test_apps
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Firefox OS Graveyard
Gaia::Homescreen
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
1.4 S6 (25apr)
Tracking | Status | |
---|---|---|
b2g-v2.0 | --- | fixed |
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Whiteboard: [c= p=4 s= u=], [systemsfe])
Attachments
(1 file)
We have a simple vertical homescreen prototype, we should land it in test_apps.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8396505 [details] [review] Github pull request Hey Vivien - would you have time to review this one? Thanks!
Attachment #8396505 -
Flags: review?(21)
Depends on: 899994
Comment 3•10 years ago
|
||
Comment on attachment 8396505 [details] [review] Github pull request I'm going to re-review it once bug 899994 is fixed. It would be awesome to start from a privileged only homescreen and on the road fix the issues that prevent third party homescreens.
Attachment #8396505 -
Flags: review?(21)
Comment 4•10 years ago
|
||
(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #3) > Comment on attachment 8396505 [details] [review] > Github pull request > > I'm going to re-review it once bug 899994 is fixed. It would be awesome to > start from a privileged only homescreen and on the road fix the issues that > prevent third party homescreens. UX wants to do user testing in 2 weeks so I don't think we can block on bug 899994. This would put the whole homescreen 2.0 at risk :(
Assignee | ||
Comment 5•10 years ago
|
||
One way forward might be to use a branch for now. Alternatively there will be a bug that "turns on" homescreen 2 by default, and we can block that bug on tasks to make it a privileged app.
Assignee | ||
Updated•10 years ago
|
Comment 6•10 years ago
|
||
Comment on attachment 8396505 [details] [review] Github pull request Let's add a stamp to land that on test_apps. However if that code goes into production at some point it will need a deeper review.
Attachment #8396505 -
Flags: review+
Assignee | ||
Comment 7•10 years ago
|
||
Landed with the understanding that we will be doing a much deeper review when it comes time to move this into the apps/ folder.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Whiteboard: [c= p=4 s= u=] → [c= p=4 s= u=], [systemsfe]
Updated•10 years ago
|
Target Milestone: --- → 1.4 S5 (11apr)
Updated•10 years ago
|
Target Milestone: 1.4 S5 (11apr) → 1.4 S6 (25apr)
Assignee | ||
Comment 8•10 years ago
|
||
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
status-b2g-v2.0:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•