987792 - The bottom part of the letter 'g' is clipped on two-line buttons in the menu panel and one-line labels in the customization palette

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

The bottom part of the letter 'g' is clipped on two-line buttons in the menu panel and one-line labels in the customization palette.

The interesting part is that in the panel we use the .multiline-toolbarbutton-text label and in the palette we use the .toolbarbutton-text label.

Comment 2

[Sören Hentzschel]

Attachment: australis-menu.png

The German "Preferences" ("Einstellungen") is affected and it looks really wrong. But the interesting part is: it looks not so bad in the first and in the third row of widgets, but in the second and in the fourth row, see the screenshot.

Comment 3

[:Gijs (he/him)]

(In reply to Sören Hentzschel from comment #2)
> Created attachment 8405543 [details]
> australis-menu.png
> 
> The German "Preferences" ("Einstellungen") is affected and it looks really
> wrong. But the interesting part is: it looks not so bad in the first and in
> the third row of widgets, but in the second and in the fourth row, see the
> screenshot.

This probably has to do with pixel snapping of rounded values and such. It's cut off everywhere. :-\

Comment 4

[:Gijs (he/him)]

Attachment: increase clip rect height,

So this fixes things on OS X, at least. I would have preferred to use a calc() expression but they don't seem to work inside rect()s... going to test this on Win8/7/XP and Linux before I ask for review, on the understanding that this is hacky but we should do /something/.

Comment 5

[:Gijs (he/him)]

Comment on attachment 8406166 [details] [diff] [review]
increase clip rect height,

Review of attachment 8406166 [details] [diff] [review]:
-----------------------------------------------------------------

This seems to work well on Windows 7/8/XP, Linux and OS X. I couldn't reproduce the palette case, so I've left that alone.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8406166 [details] [diff] [review]
increase clip rect height,

Review of attachment 8406166 [details] [diff] [review]:
-----------------------------------------------------------------

I tested this with two lines of 'ggg ggg' and a third line of 'TTT' and didn't see the third line peeking through.

Comment 7

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/026348f74a59

Comment 8

[:Gijs (he/him)]

Comment on attachment 8406166 [details] [diff] [review]
increase clip rect height,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: gs and some other descenders in the labels of panel menu buttons might get clipped under some circumstances
Testing completed (on m-c, etc.): local, soon on m-c
Risk to taking this patch (and alternatives if risky): low, although there is always the theoretical risk that our testing missed this change showing the tip of the third line of text under some font sizes; none of my manual testing showed any such thing happening, however, and it's arguably better that such a thing would happen than the current issue, as buttons with 3 lines are much more rare than buttons with 2 that have descenders in the second line.
String or IDL/UUID changes made by this patch: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/026348f74a59

Comment 10

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/23311c5022ea
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/636406913b2f

Comment 11

[Ioana (away)]

Verified as fixed with Firefox 29.0b9 de on Windows 7 64bit, Ubuntu 13.04 32bit and Mac OS X 10.9.2.

Comment 12

[Catalin Varga [QA][:VarCat]]

Verified as fixed using the following environment:
FF Aurora 30
Build Id: 20140425004002
OS: Win 7 x64, Ubuntu 13.04 x64 and Mac Os X 10.0

Comment 13

[Catalin Varga [QA][:VarCat]]

Verified as fixed using the following environment:

FF 31.0b2
Build Id: 20140505140302
OS: Win 7 x64, Mac Os X 10.7.5, Ubuntu 13.04 x64

Comment 14

[u428464]

It's not fixed completely : the g is still clipped in the customization palette (ie. one line label) on Windows 7 at least.

Comment 15

[:Gijs (he/him)]

(In reply to Guillaume C. [:ge3k0s] from comment #14)
> It's not fixed completely : the g is still clipped in the customization
> palette (ie. one line label) on Windows 7 at least.

Please file a separate bug for this.