window.open(..., '_blank') finds extant window in embedded apps

RESOLVED FIXED in mozilla0.9.5

Status

()

--
major
RESOLVED FIXED
18 years ago
18 years ago

People

(Reporter: danm.moz, Assigned: danm.moz)

Tracking

Trunk
mozilla0.9.5
All
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

18 years ago
Oops. Why the heck had no one noticed this? If your app was using WindowWatcher 
as it was supposed to, _blank wasn't properly detected, and would find an extant 
window. Mozilla has been fine because until recently, WindowWatcher wasn't 
really hooked up in Mozilla.
(Assignee)

Comment 1

18 years ago
Created attachment 48630 [details] [diff] [review]
teach WindowWatcher about _blank windows
(Assignee)

Updated

18 years ago
Blocks: 97514
(Assignee)

Comment 2

18 years ago
(to test this, once I get bug 97514 closed again, just try doing anything that 
opens a _blank window. like bug 98732, for instance.)
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.5

Comment 3

18 years ago
hey dan,

we also seem to support (at least sometimes) a window target called '_new'.  Do
we need to check for '_new' too?
(Assignee)

Comment 4

18 years ago
_new is supported inconsistently, and not in the code from which I cribbed this 
patch, but !what the heck! supporting _new as well is probably step in the 
direction of consistency. And standards hell. But we were already there. Patch is 
in, with _new.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Assignee)

Updated

18 years ago
No longer blocks: 97514
You need to log in before you can comment on or make changes to this bug.