988168 - Better integrate gtest libxul in the build system

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

The goal is for the build system to have better knowledge about what ends up in gtest/libxul.so and avoid the dual linking hack in toolkit/library.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Better integrate gtest libxul in the build system

https://tbpl.mozilla.org/?tree=Try&rev=c5bdeb20a16d
B2G KK failures can be ignored, those builds are broken.

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8397731 [details] [diff] [review]
Better integrate gtest libxul in the build system

(Stealing review from gps)

Looks good!

Since this almost completely eliminates LIBXUL_LIBRARY in moz.build files, is there a way to remove it from dom/bindings/test/moz.build as well? It seems a bit silly to have a variable that is used in only one file.

Comment 3

[Mike Hommey [:glandium]]

Filed bug 989522

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca413634eba3

Comment 5

[Mike Hommey [:glandium]]

Fixup for windows PGO
https://hg.mozilla.org/integration/mozilla-inbound/rev/a92851ff7444

Comment 6

[Mike Hommey [:glandium]]

And backed out because of a drop in linker memory usage which likely means it breaks PGO and will regress perf.
https://hg.mozilla.org/integration/mozilla-inbound/rev/2db12b4898e2

Comment 7

[Mike Hommey [:glandium]]

Rebased, moved MSVC_ENABLE_PGO from moz.build to libxul.mozbuild and relanded.
https://hg.mozilla.org/integration/mozilla-inbound/rev/93739bb52457

(with some fuckup beforehand:
   https://hg.mozilla.org/integration/mozilla-inbound/rev/3c648300596f
   https://hg.mozilla.org/integration/mozilla-inbound/rev/561b9329d832 )

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/93739bb52457

Comment 9

[Firefox Commit Bot]

The following changesets are now in Firefox Nightly:

> 561b9329d832 Bug 988168 - Better integrate gtest libxul in the build system. r=mshal
> 3c648300596f Backed out changeset 561b9329d832 (bug 988168) for wrong attribution.
> 93739bb52457 Bug 988168 - Better integrate gtest libxul in the build system. r=mshal. DONTBUILD

Nightly Build Information:

        ID: 20140402030201
 Changeset: 4941a2ac0786109b08856738019b016a6c5a66a6
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=4941a2ac0786
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central

Download Links:

>         Linux x86: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-i686.tar.bz2
>      Linux x86_64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64.tar.bz2
> Linux x86_64 ASAN: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64-asan.tar.bz2
>               Mac: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.mac.dmg
>             Win32: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win32.installer.exe
>             Win64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win64-x86_64.installer.exe

Previous Nightly Build Information:

        ID: 20140401030203
 Changeset: 1417d180a1d8665b1a91b897d1cc4cc31e7980d4
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=1417d180a1d8
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-01-03-02-03-mozilla-central