Closed
Bug 989522
Opened 11 years ago
Closed 11 years ago
Remove LIBXUL_LIBRARY from the moz.build sandbox
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla31
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 2 obsolete files)
|
8.42 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
From bug 988168 comment 2:
> Since this almost completely eliminates LIBXUL_LIBRARY in moz.build files,
> is there a way to remove it from dom/bindings/test/moz.build as well? It
> seems a bit silly to have a variable that is used in only one file.
That could probably be replaced by some DEFINES.
|
Assignee | |
Comment 1•11 years ago
|
||
That leaves LIBXUL_LIBRARY as an implementation detail in config.mk (avoiding multiple $(filter) tests).
Attachment #8399803 -
Flags: review?(mshal)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8399810 -
Flags: review?(mshal)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8399803 -
Attachment is obsolete: true
Attachment #8399803 -
Flags: review?(mshal)
|
|
Assignee | |
Comment 3•11 years ago
|
||
I will get this right.
Attachment #8399834 -
Flags: review?(mshal)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8399810 -
Attachment is obsolete: true
Attachment #8399810 -
Flags: review?(mshal)
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8399834 [details] [diff] [review]
Remove LIBXUL_LIBRARY from the moz.build sandbox
Hooray!
Attachment #8399834 -
Flags: review?(mshal) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
||
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•