Closed Bug 989522 Opened 6 years ago Closed 6 years ago

Remove LIBXUL_LIBRARY from the moz.build sandbox

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla31

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file, 2 obsolete files)

From bug 988168 comment 2:

> Since this almost completely eliminates LIBXUL_LIBRARY in moz.build files,
> is there a way to remove it from dom/bindings/test/moz.build as well? It
> seems a bit silly to have a variable that is used in only one file.

That could probably be replaced by some DEFINES.
Depends on: 988168
That leaves LIBXUL_LIBRARY as an implementation detail in config.mk (avoiding multiple $(filter) tests).
Attachment #8399803 - Flags: review?(mshal)
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Attachment #8399810 - Flags: review?(mshal)
Attachment #8399803 - Attachment is obsolete: true
Attachment #8399803 - Flags: review?(mshal)
I will get this right.
Attachment #8399834 - Flags: review?(mshal)
Attachment #8399810 - Attachment is obsolete: true
Attachment #8399810 - Flags: review?(mshal)
Comment on attachment 8399834 [details] [diff] [review]
Remove LIBXUL_LIBRARY from the moz.build sandbox

Hooray!
Attachment #8399834 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/9bd193e4b484
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.