988268 - [Cost Control] "When use is above" parameter is set to '0' the red line appearing at the top of the graphic

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Loli (:lolimartinezcr)]

Attachment: 2014-03-25-09-31-44.png

1.4
Platform version: 30.0a2
Build ID: 20140325101236
Git commit: b09bf796
Reproducible: 100%

STR:
1) Tap Usage aplication
2) Tap Setting button
3) Set "0" in "When use is above"
4) Tap "Done"

Actual result:
Line red is show (See attached image) not in 0

Expected result:
Graphics is correctly shown

Comment 1

[Noemí Freire (:noemi)]

Hi,

Just adding that same behavior is seen in today's (3/26) master and v1.3 builds:

Master
Device:hamachi
BuildId: 20140326065930
Gecko: 618b2c2
Gaia: 0c9701c
Platform version: 31.0a1

v1.3:
Device:hamachi
BuildId: 20140326055947
Gecko: 6a9a53d
Gaia: 812838a
Platform version: 28.0

It doesn't make a lot of sense to allow setting '0' value as data usage limit, we should avoid it. Asking for UX input here, Ayman wdyt?

Comment 2

[ayman maat :maat]

ok I agree with Noemi and the developers that allowing the user to set a value limit of ‘0’ makes no sense. Discussions lead me to conclude that the minimum value a user should be able to input is: 0.01 

We need a mechanism that communicates to the user that the current value input is either valid or invalid and for that I think for the sake of constancy we will use the pattern that is implemented on the cash balance alert indicator under: 

Usage App > settings > Balance ‘when balance is below’.

Therefore the specified behaviour should be as follows:

1) field empty
      field border	= red error treatment
      field fill 	= red error treatment
      done CTA		= disabled

2) 0 (zero) in field
      field border		= red error treatment
      field fill 		= red error treatment
      done CTA		= disabled

3) 0.0 (zero dot zero) in field
      field border		= red error treatment
      field fill 		= red error treatment
      done CTA		= disabled

4) 0.01 (zero dot zero one) or greater value in field
      field border	= normal treatment
      field fill 	= normal treatment
      done CTA		= enabled

Please remember to limit the amounts of decimal points (dots) ‘.’ that can be input into the field to one and not to allow the dash ‘-‘ to be input into the field at all. if this is not possible when fixing this bug then:

5) if more than one decimal point ‘.’ is input into the field or a dash ‘-‘ is input into the field
      field border	= red error treatment
      field fill 	= red error treatment
      done CTA		= disabled

Ni? me if you require any further clarification

Comment 3

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Hi, 
Salva could you review this patch?

In this patch have not addressed the issue of not allowing more than one dot, because this can be a problem if the numbers are localized.
Ayman has already opened a specific bug for this ( Bug 986414 -[Cost Control] Undesirable keyboard behaviour in data usage: user can enter multiple decimal points)

Comment 4

[Marina Rodríguez [:mai]]

Comment on attachment 8397764 [details] [review]
patch v1.0

Ayman, do you mind giving me your feedback?

Comment 5

[ayman maat :maat]

Comment on attachment 8397764 [details] [review]
patch v1.0

Seems fine to me Marina. Good work.

Comment 6

[Salvador de la Puente González [:salva]]

Comment on attachment 8397764 [details] [review]
patch v1.0

Passing to José Manuel.

Comment 7

[Jose Manuel Cantera]

I left some comments on GH. Marina, please, address them and then ask for another review

thanks!

Comment 8

[Marina Rodríguez [:mai]]

Comment on attachment 8397764 [details] [review]
patch v1.0

Hi Jose, 
I've updated the PR with your comments. Would you mind reviewing the patch again?
Regards

Comment 9

[Jose Manuel Cantera]

I've just talked to Marina and we are going to implement some enhancements (filtering out non-significative zeros), thus cancelling my review until that happens.

By the way Marina, this PR would also need some tests

thanks!

Comment 10

[Marina Rodríguez [:mai]]

Comment on attachment 8397764 [details] [review]
patch v1.0

Updated the PR with your comments. Added some test.

Jose, would you mind reviewing the patch?

Regards

Comment 11

[Jose Manuel Cantera]

Comment on attachment 8397764 [details] [review]
patch v1.0

cancelling review as we need at least another round

Comment 12

[Marina Rodríguez [:mai]]

Comment on attachment 8397764 [details] [review]
patch v1.0

Updated the PR with your comments.
Jose, would you mind reviewing the patch?

Comment 13

[Jose Manuel Cantera]

Comment on attachment 8397764 [details] [review]
patch v1.0

still we need another round

thanks

Comment 14

[Marina Rodríguez [:mai]]

Comment on attachment 8397764 [details] [review]
patch v1.0

Updated the PR with the latest comments.

Comment 15

[Jose Manuel Cantera]

Comment on attachment 8397764 [details] [review]
patch v1.0

r+ with a tiny comment on GH to be implemented

once solve the tiny comment and a green Travis, please land

thanks!

Comment 16

[Marina Rodríguez [:mai]]

Master: e6e1da035ea6d6ca67db5a774384c55bdcaf4c5c

Comment 19

[Loli (:lolimartinezcr)]

This bug NOT is working
Tested
Hamachi
1.4
Gecko 2f11e3a
Gaia 17fb448

Comment 20

[Loli (:lolimartinezcr)]

(In reply to Loli from comment #19)
> This bug NOT is working
> Tested
> Hamachi
> 1.4
> Gecko 2f11e3a
> Gaia 17fb448

For this reason, it is reopened

Comment 21

[Loli (:lolimartinezcr)]

Sorry this bug is working in 2.0.

Comment 22

[Loli (:lolimartinezcr)]

Tested and working
Hamachi
2.0
Gecko: 6558278
Gaia: b368142