Closed Bug 988362 Opened 7 years ago Closed 7 years ago

[STK]The maxlength of the inputbox didn't set corretly in GET_INPUT command. (Increment wait time)

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(blocking-b2g:1.3+, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)

RESOLVED FIXED
1.4 S4 (28mar)
blocking-b2g 1.3+
Tracking Status
b2g-v1.3 --- fixed
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: frsela, Assigned: frsela)

References

Details

Attachments

(1 file)

At bug 893614 we added a workaround for bug 818270 (Changing maxlength on an input with display: none doesn't change the maxlength)

In bug 895314 was commented that this workaround fails in some tests, but increasing the time fix the issue (https://bugzilla.mozilla.org/show_bug.cgi?id=895314#add_comment)
That's OK. Thanks a lot!
Comment on attachment 8397127 [details] [review]
Patch to fix https://bugzilla.mozilla.org/show_bug.cgi?id=895314#c2

f+ based in the last comment ;)
r?
Attachment #8397127 - Flags: review?(timdream)
Attachment #8397127 - Flags: feedback?(chenxk)
Attachment #8397127 - Flags: feedback+
Attachment #8397127 - Flags: review?(timdream) → review+
Thank you Tim ! :)

I suppose we should land this path in master without unit test since I'm working in other related bugs in the unit tests for STK in System.

Do you agree to land this one now?
Flags: needinfo?(timdream)
(In reply to Fernando R. Sela (no CC, needinfo please) [:frsela] from comment #5)
> Thank you Tim ! :)
> 
> I suppose we should land this path in master without unit test since I'm
> working in other related bugs in the unit tests for STK in System.
> 
> Do you agree to land this one now?

I don't think this particular change is testable, so just land it then.
Flags: needinfo?(timdream)
Landed: https://github.com/mozilla-b2g/gaia/commit/e7792debddfb9f72e10190b3e763afbb48b0c7c1
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee: nobody → frsela
Target Milestone: --- → 1.4 S4 (28mar)
Comment on attachment 8397127 [details] [review]
Patch to fix https://bugzilla.mozilla.org/show_bug.cgi?id=895314#c2

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

This patch is needed to land 989852 without race-condition issue
[User impact] if declined: Low
[Testing completed]: Not needed, only changes a timeout. Tests will be provided in 989852
[Risk to taking this patch] (and alternatives if risky): None
Attachment #8397127 - Flags: approval-gaia-v1.4?(release-mgmt)
Attachment #8397127 - Flags: approval-gaia-v1.3?(release-mgmt)
Nominating to v1.3 and v1.4 since it blocks a blocker (Bug 989852)
Per comment 9 setting 1.3? flag
blocking-b2g: --- → 1.3?
Attachment #8397127 - Flags: approval-gaia-v1.4?(release-mgmt)
Attachment #8397127 - Flags: approval-gaia-v1.4+
Attachment #8397127 - Flags: approval-gaia-v1.3?(release-mgmt)
Attachment #8397127 - Flags: approval-gaia-v1.3+
blocking-b2g: 1.3? → 1.3+
You need to log in before you can comment on or make changes to this bug.