988362 - [STK]The maxlength of the inputbox didn't set corretly in GET_INPUT command. (Increment wait time)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

At bug 893614 we added a workaround for bug 818270 (Changing maxlength on an input with display: none doesn't change the maxlength)

In bug 895314 was commented that this workaround fails in some tests, but increasing the time fix the issue (https://bugzilla.mozilla.org/show_bug.cgi?id=895314#add_comment)

Comment 1

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Patch to fix https://bugzilla.mozilla.org/show_bug.cgi?id=895314#c2

Comment 2

[xiaokang.chen]

That's OK. Thanks a lot!

Comment 3

[xiaokang.chen]

Comment on attachment 8397127 [details] [review]
Patch to fix https://bugzilla.mozilla.org/show_bug.cgi?id=895314#c2

That's OK. Thanks a lot!

Comment 4

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Comment on attachment 8397127 [details] [review]
Patch to fix https://bugzilla.mozilla.org/show_bug.cgi?id=895314#c2

f+ based in the last comment ;)
r?

Comment 5

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Thank you Tim ! :)

I suppose we should land this path in master without unit test since I'm working in other related bugs in the unit tests for STK in System.

Do you agree to land this one now?

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Fernando R. Sela (no CC, needinfo please) [:frsela] from comment #5)
> Thank you Tim ! :)
> 
> I suppose we should land this path in master without unit test since I'm
> working in other related bugs in the unit tests for STK in System.
> 
> Do you agree to land this one now?

I don't think this particular change is testable, so just land it then.

Comment 7

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Landed: https://github.com/mozilla-b2g/gaia/commit/e7792debddfb9f72e10190b3e763afbb48b0c7c1

Comment 8

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Comment on attachment 8397127 [details] [review]
Patch to fix https://bugzilla.mozilla.org/show_bug.cgi?id=895314#c2

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

This patch is needed to land 989852 without race-condition issue
[User impact] if declined: Low
[Testing completed]: Not needed, only changes a timeout. Tests will be provided in 989852
[Risk to taking this patch] (and alternatives if risky): None

Comment 9

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Nominating to v1.3 and v1.4 since it blocks a blocker (Bug 989852)

Comment 10

[Noemí Freire (:noemi)]

Per comment 9 setting 1.3? flag

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/42c4fc535db0dedbecd8b0ecd98a26eb90c8d6cf
v1.3: https://github.com/mozilla-b2g/gaia/commit/67dafc6ea4ca1f8c0355d7ad337337fbc2cd3cf9

I'll go ahead and assume that this is 1.3+ since it was approved.