895314 - Remove workaroud on Bug 893614 - [STK]The maxlength of the inputbox didn't set corretly in GET_INPUT command.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

The workaround created in 893614 caused for the 818270 bug should be removed as soon as bug 818270 is landed

Comment 1

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Proposed patch when 818270 is fixed

Comment 2

[xiaokang.chen]

Dear Fernando,
The latest code still not OK on v1.3:

444       // Workaround. See bug #818270. Followup: #895314
445       setTimeout(function workaround_bug818270() {
446         self.icc_input_box.maxLength = options.maxLength;
447         self.icc_input_box.value = options.defaultText || '';
448       });

What do you think? We can't always waive this.

Comment 3

[Jason Smith [:jsmith]]

Not a regression, so not blocking.

Comment 4

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to xiaokang.chen from comment #2)
> Dear Fernando,
> The latest code still not OK on v1.3:
> 
> 444       // Workaround. See bug #818270. Followup: #895314
> 445       setTimeout(function workaround_bug818270() {
> 446         self.icc_input_box.maxLength = options.maxLength;
> 447         self.icc_input_box.value = options.defaultText || '';
> 448       });
> 
> What do you think? We can't always waive this.

Hi,

This is an old bug in the input box control of Gecko. The related bug shall be fixed first.

This is only a workaround to display the control and after that change the maxlength and value attributes.

This can fail by a race condition since this timeout is fired asap (no timer defined) ... we can increase it to 500ms or so...

WDYT?
Any other idea for a better workaround?

Comment 5

[xiaokang.chen]

Dear fernando,
I can't reproduce when I try 500ms, it works maybe. And I will let the qa try the new code in lab, if it work, we can merge the code. I will inform you if I got the result!

Comment 6

[xiaokang.chen]

Dear Fernando,
500ms works OK. QA didn't reproduce this bug in lab with 500ms delay. Thanks a lot!

Comment 7

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to xiaokang.chen from comment #6)
> Dear Fernando,
> 500ms works OK. QA didn't reproduce this bug in lab with 500ms delay. Thanks
> a lot!

Creating a new bug (988362) to add this proposal since this one is to *remove* these workarounds ;)

Comment 8

[BMO Automation]

Firefox OS is not being worked on