Closed
Bug 988447
Opened 11 years ago
Closed 11 years ago
Define behavior of de-duping/merging multiple link providers
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
VERIFIED
FIXED
Firefox 32
People
(Reporter: Mardak, Assigned: jboriss)
References
Details
(Whiteboard: p=3 s=it-32c-31a-30b.2 [qa-])
Bug 975228 adds directory links as another provider using the merge logic from bug 911307. adw seems to be adding exact match de-duping in bug 911307 but we might want something more or different. clarkbw, perhaps for the initial landing, the exact match de-duping is enough? Where I would guess the history tile replaces the directory tile?
Flags: needinfo?(clarkbw)
Updated•11 years ago
|
Whiteboard: p=0
Reporter | ||
Comment 1•11 years ago
|
||
MarcoM, what the p=0 in relation to firefox-backlog flag? Is it just that this wasn't prioritized but in the backlog?
Comment 2•11 years ago
|
||
Hi Ed, the p= tag is used to the point estimation value. When it is p=0 it means the bug hasn't gone through the estimation process.
Comment 3•11 years ago
|
||
(In reply to Ed Lee :Mardak from comment #0) > Bug 975228 adds directory links as another provider using the merge logic > from bug 911307. adw seems to be adding exact match de-duping in bug 911307 > but we might want something more or different. > > clarkbw, perhaps for the initial landing, the exact match de-duping is > enough? Where I would guess the history tile replaces the directory tile? Yeah, for now an exact match replacement would probably work just fine. It would be nice to know this happened through a metric but not required.
Flags: needinfo?(clarkbw)
Updated•11 years ago
|
Flags: firefox-backlog+
Updated•11 years ago
|
No longer blocks: fxdesktopbacklog
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → jboriss
Updated•11 years ago
|
Whiteboard: p=0 → p=3 s=IT-32c-31a-30b.1 [qa?]
Updated•11 years ago
|
Whiteboard: p=3 s=IT-32c-31a-30b.1 [qa?] → p=3 s=IT-32c-31a-30b.1 [qa-]
Updated•11 years ago
|
Status: NEW → ASSIGNED
Updated•11 years ago
|
Whiteboard: p=3 s=IT-32c-31a-30b.1 [qa-] → p=3 s=it-32c-31a-30b.2 [qa-]
Assignee | ||
Comment 4•11 years ago
|
||
As Bryan notes in Comment 3, exact matches should absolutely not produce dupes. In other words, faceboook.com as a Sponsored provider and facebook.com as an organic link the user has visited should not produce a secondary tile, and if the user deleted the Sponsored tile he should not see another for facebook.com. For non-exactly matches, let's start by identifying redirects that are essentially the same. For instance, ebay.com = www.ebay.com = http://wwww.ebay.com/loggedin=refererfirefox = etc. If the page is the same, they should not produce a duplicate. This will be particularly important on sites with logins, such as Gmail. Currently, we should the whole URL string instead of title for some logged out pages ( http://cl.ly/image/211a3X143o1T and http://cl.ly/image/0r1j21070Y13 ), when what we should be showing is simply Gmail. Defining how to implement this will be non-trivial, and I'll create a followup bug for that.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
Updated•11 years ago
|
Target Milestone: --- → Firefox 32
You need to log in
before you can comment on or make changes to this bug.
Description
•