988571 - Migrate Android Firefox Accounts from Doghouse to Separated state on application upgrade

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Nick Alexander :nalexander [he/him]]

We just haven't gotten to this: we have the ability to move an account to the Doghouse state, but the user has no way to recover.  We should migrate accounts from the Doghouse state to the Separated state upon application upgrade.

Technically, this means adding an additional BroadcastReceiver listening for MY_UPGRADE, just like http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/sync/receivers/UpgradeReceiver.java.

Comment 1

[Nick Alexander :nalexander [he/him]]

rnewman reminds me that we don't actually Doghouse anybody yet:

15:14 rnewman: nalexander: do we ever put folks in Doghouse?
15:14 nalexander: rnewman: yes, but only when the server requests it.
15:15 rnewman: and does it?
15:15 nalexander: rnewman: not yet.  Although, now I'm not so sure.  Looks like only when Crypto fails :)
15:15 nalexander: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/fxa/login/Engaged.java#53

In fact, we haven't implemented this at the right point:

15:15 nalexander: rnewman: wat: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/fxa/activities/FxAccountUpdateCredentialsActivity.java#119

But the logic is in place:

15:16 nalexander: rnewman: ah, I see http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/fxa/login/BaseRequestDelegate.java#25

So this should really be, Doghouse when appropriate, and also move Doghouse to Separated on upgrade.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/442

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8397600 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/442

Just realized I didn't add the commit to move Doghouse to Separated on update.  Tomorrow.

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8397600 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/442

That's better.  Additional commit pushed, ready for review.

Comment 5

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/f3c4b591b156

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f3c4b591b156