988610 - [Camera][Madai] Black screen when opening camera from lockscreen and camera app isn't open

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect, P1)

Description

[Marcia Knous [:marcia]]

Attachment: Logcat captured while testing in camera app

Buri, while running with the latest master.

Gaia   5ae2df02e30bda2ae04830d6e181ecf31ff38817
SourceStamp c69c55582faa
BuildID 20140326040202
Version 31.0a1

STR:
1. Lock the screen using the power button.
2. Swipe to the left to open camera.
3. Observe a black screen.

Logcat attached.

I checked a recent build on Nexus 4 and the issue doesn't exist.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Marcia: I just confirmed this is happening on my Hamachi as well. I noticed though that if the camera app is running and you return to homescreen and lock the phone, you can re-open the camera from the lockscreen. However, if you terminate the Camera app and then try opening it from the lock screen, it ends up at a black screen as you described.

Comment 2

[Hema Koka [:hema]]

Marking this a blocker (regression after merge from madai camera features branch)

Comment 3

[Marcia Knous [:marcia]]

Confirming Justin's comment that it doesn't happen if the camera app is open on both devices.

Comment 4

[Mike Habicher [:mikeh] (high bugzilla latency)]

Unfortunately the logcat doesn't show anything related to the camera (the word 'camera' doesn't appear anywhere in it).

Comment 5

[Hema Koka [:hema]]

Mike/Justin, we need one of you to dig in to see whats going on. 

Thanks
Hema

Comment 6

[Justin D'Arcangelo [:justindarc]]

The following JS error is visible in the logcat when reproducing this:

E/GeckoConsole( 2688): [JavaScript Error: "types.forEach is not a function" {file: "app://camera.gaiamobile.org/js/main.js" line: 6011}]
E/GeckoConsole( 2688): [JavaScript Error: "NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "types.forEach is not a function" {file: "app://camera.gaiamobile.org/js/main.js" line: 6011}]'[JavaScript Error: "types.forEach is not a function" {file: "app://camera.gaiamobile.org/js/main.js" line: 6011}]' when calling method: [nsIDOMSystemMessageCallback::handleMessage]" {file: "null" line: 0}]

`types.forEach` is referring to line 141 in lib/activity.js:
https://github.com/mozilla-b2g/gaia/blob/master/apps/camera/js/lib/activity.js#L141

Comment 7

[Justin D'Arcangelo [:justindarc]]

Also: Black screen when launching Camera from Gallery app (when Camera was not already previously running). Both of these issues have the same root cause. Submitting a PR now.

Comment 8

[Justin D'Arcangelo [:justindarc]]

Attachment: pull-request (master)

Comment 9

[David Flanagan [:djf]]

Comment on attachment 8398133 [details] [review]
pull-request (master)

The patch probably fixes the bug, but the code around the patch is so bad to begin with that I'd like to take this opportunity to request a bigger, better fix.

Ideally: the getModes() function would only be called for pick activities and not for the "record" activity that we use to invoke the camera.

Failing that, the logic of the getModes() function needs to be cleaned up and commented. Because right now it seems incoherent to me.

Comment 10

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8398133 [details] [review]
pull-request (master)

David: I have cleaned up the code in activity.js. I think it is much easier to understand now. Please re-review. Thanks!

Comment 11

[David Flanagan [:djf]]

Comment on attachment 8398133 [details] [review]
pull-request (master)

A couple of bugs and a couple of suggestions.  See github.

Comment 12

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8398133 [details] [review]
pull-request (master)

David: Please re-review and let me know if this looks ok. The app is now properly handling the 'record' activities and setting the correct `mode` (e.g.: picture, video) accordingly. So, the Gallery app will launch the Camera in the 'picture' mode by default, whereas the Video app will launch in the 'video' mode. Also, unit tests have been added/updated for everything in this patch.

Comment 14

[David Flanagan [:djf]]

Comment on attachment 8398133 [details] [review]
pull-request (master)

r+ with nits addressed.

Most of my comments are requests for more comments in the code.

One of them seems like it might be a bug: I think the picture mode gets configured twice when the Camera is launched by activity, and I think lib/activity.js is taking over the definition of the default mode from config/app.js

I can review again if you'd like but if you address my nits and test carefully you can land this without re-review.

Comment 15

[Florin Strugariu [:Bebe]]

We can reproduce this in the today's automation build:

Gaia      874fe42b82e8d819d592690e74db91c07179e68c
Gecko     https://hg.mozilla.org/mozilla-central/rev/1417d180a1d8
BuildID   20140401040202
Version   31.0a1
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013

Comment 16

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/089f8ced32c2079f51f3c59eebada749b4880aae

Comment 17

[David Flanagan [:djf]]

Bulk edit for camera bugs.

If earlier comments do not show how this bug landed to master, it probably landed as part of https://github.com/mozilla-b2g/gaia/pull/17599 which merged the camera-new-features branch into master.

This bug was uplifted from master to v1.4 as part of https://github.com/mozilla-b2g/gaia/commit/a8190d08e61316a86bba572ba8d894d081a20530

Comment 18

[sarsenyev]

The bug is no longer reproduces on the latest 1.4 and master builds
No black screen appears when the camera is opened from "Lock" screen

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140408000202
Gaia: 26983f356ecb1bcf30e862d334b5de790071803e
Gecko: 70b076fc7558
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Master Environmental Variables:
Device: Buri Master 
BuildID: 20140408040204
Gaia: 1958454595b1fa0e061f0652ae965629993f5708
Gecko: 8883360b1edb
Version: 31.0a1
Firmware Version: v1.2-device.cfg