988621 - TypeError: IccHelper.iccInfo is null

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Anshul]

I am seeing the following error intermittently after reboot and consistently during our internal marionette test scripts.

TypeError: IccHelper.iccInfo is null at: app://system.gaiamobile.org/js/call_forwarding.js line: 85

We need a if (IccHelper.iccInfo && IccHelper.iccInfo.iccid) check around block of code on line 85 as done in other JS files that use iccid. Please see bug 914673 as as reference.

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

Adding a check looks good to me. However, I was curious about why there is no iccInfo when cfstatechange. Are the tests being done using a dual sim device? There is no dual sim support for call forwarding in v1.3.

Comment 2

[Anshul]

(In reply to Arthur Chen [:arthurcc] from comment #1)
> Adding a check looks good to me. However, I was curious about why there is
> no iccInfo when cfstatechange. 
I tried to debug that but the issue happens randomly so I couldn't get very far with my debugging session.
> Are the tests being done using a dual sim
> device? There is no dual sim support for call forwarding in v1.3.
Single SIM.

Comment 3

[Preeti Raghunath(:Preeti)]

Inder,

Can we please help understand if 1.3 or 1.4 is a higher priority?

Comment 4

[Inder]

:Preeti -- this is a good to have things and as per my understanding is a 2 line fix to do the null check so shouldn't be difficult to get it fixed. But, if there is a resource conflict then 1.4 issues are higher priority than this particular issue. Currently, as a workaround we have put in a temporary fix in our build.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/17747

Alive, could you help review the simple patch?

Comment 6

[Gregor Wagner [:gwagner]]

Tim, can you do the blocking triage here?

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8398410 [details]
link to https://github.com/mozilla-b2g/gaia/pull/17747

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Unknown gecko issue
[User impact] if declined: No big impact to users but we will see javascript errors in the console.
[Testing completed]: N/A
[Risk to taking this patch] (and alternatives if risky): Pretty low as the patch simply adds a null check.
[String changes made]: N/A

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

By [Testing completed]: N/A, I meant manual testing completed.

Comment 9

[Gregor Wagner [:gwagner]]

Comment on attachment 8398410 [details]
link to https://github.com/mozilla-b2g/gaia/pull/17747

Stealing since Fabrice is out.

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

v1.3: 24f562fce468fc948ac9e6185e002c23350cb9ee

Comment 11

[Ryan VanderMeulen [:RyanVM]]

So we aren't landing this on v1.4/v1.5?

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

There are already null checks in both branches.