988644 - reviewer (and dev) instance of APK Factory should set android:debuggable flag

Status: RESOLVED FIXED

(Marketplace Graveyard :: Integration, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

The reviewer (and dev) instance of the APK Factory is supposed to set the android:debuggable attribute in AndroidManifest.xml to "true", so the remote debugger server starts in app processes, and developers (and reviewers) can attach remote developer tools to apps.  But that isn't happening.

android:debuggable is described here:

http://developer.android.com/guide/topics/manifest/application-element.html

This resource suggests "ant debug" is the equivalent of "ant release" but sets the flag:

http://stackoverflow.com/questions/4580595/what-would-happen-if-android-app-is-released-with-debuggable-on

Comment 1

[Austin King [:ozten]]

If I switch to `ant debug` instead of `ant release`, I'm getting

    Error: SIGNER_REFUSED_REQUEST

Proposed fix
https://github.com/mozilla/apk-factory-service/pull/63

ant debug output
http://pastebin.mozilla.org/4695450

this build step results in

    bin/FbImport-debug.apk
    bin/FbImport-debug-unaligned.apk

I'm passing FbImport-debug.apk over to the signer.

Comment 2

[Austin King [:ozten]]

I've ask for review in the pull request, adding needs info flag here also.

Comment 3

[Kumar McMillan [:kumar]]

(In reply to Austin King [:ozten] from comment #1)
> If I switch to `ant debug` instead of `ant release`, I'm getting
> 
>     Error: SIGNER_REFUSED_REQUEST

Could you grab the actual response/status from here? https://github.com/mozilla/apk-factory-service/blob/master/lib/apk_signer_client.js#L51-L52

Comment 4

[Austin King [:ozten]]

Thanks for the review.

Of course it's working now that I went to capture the error.

Comment 5

[Austin King [:ozten]]

Fixed in e54dd9bf7e53

Deployment to dev failed, filed bug#988912

Comment 6

[Austin King [:ozten]]

In my integration tests, I'm seeing

    SigningError: Failed to sign APK: ID 441cb9e98bae62ac93d29794dcc4c0ba8c76c206: jarsigner failed: jarsigner: unable to sign jar: java.util.zip.ZipException: invalid entry compressed size (expected 469 but got 468 bytes)

http://sentry.shared.us-east-1.stage.mozaws.net/apk/apk-signer-stage/group/4594/

Comment 7

[Austin King [:ozten]]

We should not call into the APK Signer for reviewer builds.

We'll call `ant debug` and then stream the resulting .apk back to the client.

Background:
Sample Debug APK http://ozten.com/random/apk-factory/TestAppdeltron30333review-debug.apk looks good to myk, except for a client side issue to be investigated around remote debugging.

Comment 8

[Austin King [:ozten]]

Fixed in https://github.com/mozilla/apk-factory-service/pull/68

Queueing up for release today to stage in release-2014-04-02-01

Comment 9

[Austin King [:ozten]]

This is staged, ready for testing.

Comment 10

[Austin King [:ozten]]

myk and/or jhugman can you verify that the apk has the properties you want out of a debuggable apk?

    curl https://apk-controller-review.stage.mozaws.net/application.apk?manifestUrl=http://chat.messageme.com/manifest.webapp -o messageme.apk

Comment 11

[Myk Melez [:myk] [@mykmelez]]

(In reply to Austin King [:ozten] from comment #10)
> myk and/or jhugman can you verify that the apk has the properties you want
> out of a debuggable apk?

I would love to!  But currently I'm hitting bug 993164 when I try to download the APK, so I'll watch that bug and try again once it's resolved.  In the meantime, I'll leave the needinfo request here to remind me to come back to this.

Comment 12

[Myk Melez [:myk] [@mykmelez]]

Although I'm still seeing bug 993164 right now, I did manage to download an APK from stage-review yesterday (on the second attempt), and I was able to confirm that the android:debuggable attribute is set to "true" in the APK's AndroidManifest.xml file, and the remote debugger server starts when the app is launched!  So this has indeed been resolved.

Comment 13

[Iulian Timis]

Please add STR here or mark it with [qa-] if no QA is needed.

Comment 14

[James Hugman [:jhugman] [@jhugman]]

MessageMe shows the debuggable flag set correctly.