989041 - [apk] ANDROID_SDK_HOME not set for APK Generator Review instance

Status: RESOLVED FIXED

(Cloud Services :: Operations: Marketplace, task, P2)

Description

[Austin King [:ozten]]

I'm trying to test a fix on APK Factory generator review instance.

I'm seeing:

http://sentry.shared.us-east-1.stage.mozaws.net/apk/apk-generator-reviewstagemozawsnet/group/4786/

    Make sure the environment variable ANDROID_SDK_HOME is set up.

Comment 1

[Jason Thomas [:jason]]

https://github.com/mozilla-services/puppet-config/commit/84b3ddb413740ba836f937f9176d748ada227bf6 to set ANDROID_SDK_HOME. 

I am now seeing http://sentry.shared.us-east-1.stage.mozaws.net/apk/apk-generator-reviewstagemozawsnet/group/4932/

The ant build process is trying to write to $ANDROID_SDK_HOME/.android/debug.keystore. We should not write to this path and define another location for debug.keystore.

Comment 2

[Jason Thomas [:jason]]

ANDROID_SDK_HOME is configured. Bug 989510 to address issues on comment 1.

Comment 3

[Austin King [:ozten]]

Okay, it turns out that ANDROID_SDK_HOME has to be set to something... anything that the apk_prod user can read.

One way to fix this:

    sudo -u apk_prod mkdir /tmp/debug_keystore
    export ANDROID_SDK_HOME=/tmp/debug_keystore

The ant build is a bit of a rube goldberg machine, but it sees that there is no keystore under /tmp/debug_keystore/.android/debug.keystore and keeps on rolling along.

I believe this will fix the deployment.

Comment 4

[Austin King [:ozten]]

Stage looks good, so closing this.

Comment 5

[Austin King [:ozten]]

This problem is back for production review instance.

    Make sure the environment variable ANDROID_SDK_HOME is set up.

shows up in https://kibana.shared.us-west-2.prod.mozaws.net/#/dashboard/elasticsearch/APK-Log-Search

Perhaps we can fix this in today's 2pm release.

Comment 6

[Jason Thomas [:jason]]

This variable is set for review and the process hasn't been restarted since May 19th. Is there something strange happening here with nodejs?

[root@ip-172-31-22-254 ~]# cat /proc/3302/environ
TERM=xterm-256colorSUPERVISOR_SERVER_URL=unix:///var/tmp/supervisor.sockSHLVL=2CONFIG_FILES=/etc/apk-factory/generator.jsSUPERVISOR_ENABLED=1SUPERVISOR_PROCESS_NAME=generatorPWD=/SUPERVISOR_GROUP_NAME=generatorANDROID_HOME=/opt/adt/sdkPATH=/bin:/usr/bin:/opt/adt/sdk/toolsJAVA_HOME=/usr/lib/jvm/java-1.7.0ANDROID_SDK_HOME=/tmp/android_=/usr/bin/supervisord

[root@ip-172-31-14-111 ~]# cat /proc/2617/environ
TERM=linuxSUPERVISOR_SERVER_URL=unix:///var/tmp/supervisor.sockSHLVL=2CONFIG_FILES=/etc/apk-factory/generator.jsSUPERVISOR_ENABLED=1SUPERVISOR_PROCESS_NAME=generatorPWD=/SUPERVISOR_GROUP_NAME=generatorANDROID_HOME=/opt/adt/sdkPATH=/bin:/usr/bin:/opt/adt/sdk/toolsJAVA_HOME=/usr/lib/jvm/java-1.7.0ANDROID_SDK_HOME=/tmp/android_=/usr/bin/supervisord

Comment 7

[Jason Thomas [:jason]]

As per IRC, I've created the home directory for the apk user and configured ANDROID_SDK_HOME to the user's home directory. This has been deployed to stage.

https://github.com/mozilla-services/puppet-config/pull/533/commits

Comment 8

[Austin King [:ozten]]

Just verifying our current state:

dev review - https://apk-controller-review.dev.mozaws.net - good
stage review - https://apk-controller-review.stage.mozaws.net - good
prod review -  https://controller-review.apk.firefox.com - bad 504

Comment 9

[Austin King [:ozten]]

And with prod deployed...

prod review -  https://controller-review.apk.firefox.com - good

Comment 10

[Martijn Wargers (dead)]

https://apk-controller-review.dev.mozaws.net/ returns an untrusted connection page, because the certificate has expired (7/14/15, 2:00 PM)

Trying to use mozilla-apk-cli results in:
(gaia-py-latest)mwargers:firebeat mwargers$ mozilla-apk-cli /Users/mwargers/B2G/firebeat/ firebeat.apk
Building with https://controller-review.apk.firefox.com
Generator response status code was 504

After that I didn't get the .apk.

Comment 11

[Martijn Wargers (dead)]

Myk, see comment 10. Is this still supposed to work? Or is it currently not possible to generate an .apk from a packaged app?

Comment 12

[Myk Melez [:myk] [@mykmelez]]

It's still supposed to work, and it did work for me just now.  Can you retest?

07-29 11:27 > mozilla-apk-cli /Users/myk/Projects/mykzilla mykzilla.apk
Building with https://controller-review.apk.firefox.com
APK file is available at mykzilla.apk

Comment 13

[Martijn Wargers (dead)]

Ok, it works for the firefox-os-loop-client (although it takes quite a while without giving me any info whatsoever).
I guess it's just erroring for some reason on the firebeat app: https://github.com/loreV/firebeat.git

But shouldn't the tool give me some information on what it is erroring about?

Comment 14

[Myk Melez [:myk] [@mykmelez]]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #13)
> Ok, it works for the firefox-os-loop-client (although it takes quite a while
> without giving me any info whatsoever).
> I guess it's just erroring for some reason on the firebeat app:
> https://github.com/loreV/firebeat.git

Indeed, I see the same thing.  I reported it as https://github.com/mozilla/apk-cli/issues/7.


> But shouldn't the tool give me some information on what it is erroring about?

Ideally, yes, it would give you more information than the obscure message about the generator response status code. :-/