988670 - [Camera][Madai] Behavior when leaving camera while in preview mode and hitting home button needs to be reconsidered

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, enhancement)

Description

[Marcia Knous [:marcia]]

Buri, while running with the latest master.

Gaia   5ae2df02e30bda2ae04830d6e181ecf31ff38817
SourceStamp c69c55582faa
BuildID 20140326040202
Version 31.0a1

STR:

1. Open the camera app
2. Select the button on the left to open the previews.
3. While in preview mode hit the home button.
4. Open the camera app again

Expected: The camera app would open and I would see the viewfinder so I can take a picture

Actual: I am taken back to the gallery view and have to long press on the screen to get back into camera

Comment 1

[Hema Koka [:hema]]

Agreed, user would most likely expect the viewfinder to show up when you go to homescreen and come back. This is typical in other android based phones as well.

Amy/Tif - your input?

Comment 2

[Amy Lee [:amylee] UX]

(In reply to Hema Koka [:hema] from comment #1)
> Agreed, user would most likely expect the viewfinder to show up when you go
> to homescreen and come back. This is typical in other android based phones
> as well.
> 
> Amy/Tif - your input?

I agree, when you enter back to camera from the homescreen it should take you to the viewfinder and not back to the image preview.

Comment 3

[Tiffanie Shakespeare [:tif]]

Confirm - let's go straight back to the viewfinder when camera is reopened.

Comment 4

[Hema Koka [:hema]]

wilson - please take a look when your blockers are done

Comment 5

[Stephany Wilkes]

Axel, flagging you for insight on whether these numbers get localized (guessing not)?

Comment 6

[Youngjun Kim]

Hyuna can take it.

Comment 7

[hyuna.cho]

If we close the preview gallery when press the home button, it's affect to the below situation

case 1.
1) Take a picture and Click the preview button
2) Press the power key to turn off the screen
3) Turn on the screen
4) Now display opened the preview

case 2.
1) Take a picture and Click the preview button
2) Click the gallery button on the preview
3) Click camera button on Gallery app
4) Now display opened the preview

If we change the scenario about pressing home button, the preview will close in case of case 1/case 2 also.

We can't distinguish whether user press the home button or not in camera app.

Please check the scenario about all visibility states

Comment 8

[Axel Hecht [:Pike]]

(In reply to Stephany Wilkes from comment #5)
> Axel, flagging you for insight on whether these numbers get localized
> (guessing not)?

I don't see numbers in this bug, not sure. Right bug?

Comment 9

[Wilson Page [:wilsonpage]]

Agreed. I think it's right to close the preview gallery whenever the app is minimised.

Comment 10

[Tiffanie Shakespeare [:tif]]

I think that's fine - to always go back to the viewfinder. The primary goal of this app is to take photos and I would rather have someone have to take an extra tap to get back to preview than miss a double rainbow moment.

I don't think people will be confused as the viewfinder will give them immediate feedback that they are in camera mode.

Asking Rob for his input...

Comment 11

[Amy Lee [:amylee] UX]

(In reply to hyuna.cho from comment #7)
> If we close the preview gallery when press the home button, it's affect to
> the below situation
> 
> case 1.
> 1) Take a picture and Click the preview button
> 2) Press the power key to turn off the screen
> 3) Turn on the screen
> 4) Now display opened the preview
> 
> case 2.
> 1) Take a picture and Click the preview button
> 2) Click the gallery button on the preview
> 3) Click camera button on Gallery app
> 4) Now display opened the preview
> 
> If we change the scenario about pressing home button, the preview will close
> in case of case 1/case 2 also.
> 
> We can't distinguish whether user press the home button or not in camera app.
> 
> Please check the scenario about all visibility states

I agree with Tiff on this one. If you minimize and reopen, I think it's okay that it goes back to camera

Comment 12

[Marcia Knous [:marcia]]

We discussed this in triage yesterday and I think we are all in agreement regarding the change.

Comment 13

[hyuna.cho]

Attachment: PR-988670.html

Comment 14

[Wilson Page [:wilsonpage]]

This needs to come with a simple unit-test:

'Should close the the preview-gallery on blur'

Comment 15

[Wilson Page [:wilsonpage]]

Comment on attachment 8401006 [details]
PR-988670.html

Missing unit-tests to define this spec.

Comment 16

[hyuna.cho]

Comment on attachment 8401006 [details]
PR-988670.html

I updated the UT code. Please check it.

Comment 17

[Rob MacDonald [:robmac]]

(In reply to Tiffanie Shakespeare from comment #10)
> I think that's fine - to always go back to the viewfinder. The primary goal
> of this app is to take photos and I would rather have someone have to take
> an extra tap to get back to preview than miss a double rainbow moment.
> 
> I don't think people will be confused as the viewfinder will give them
> immediate feedback that they are in camera mode.
> 
> Asking Rob for his input...

Agreed.

Comment 18

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Patch needed a rebase.

Comment 19

[Wilson Page [:wilsonpage]]

Landed on 'master': https://github.com/mozilla-b2g/gaia/commit/243e4ef0377302c0ed29e37eb57a606d5e7615e3

Comment 21

[David Flanagan [:djf]]

Marking this 1.4+ so we can uplift to 1.4.  This patch is required for 1.4+ bug 1001503.

Comment 22

[Justin D'Arcangelo [:justindarc]]

Attachment: pull-request (v1.4)

Pull Request for v1.4 -- carrying R+ forward

Comment 23

[Justin D'Arcangelo [:justindarc]]

Landed on v1.4:

https://github.com/mozilla-b2g/gaia/commit/e66d30c262402bf14fbcbccc4aff44e7a09687fd

Comment 24

[Brogan Zumwalt [Inactive]]

New test case needs to be written to address bug.

Comment 25

[KTucker [:KTucker][Inactive 3/4/2016]]

Test case added in moztrap:

https://moztrap.mozilla.org/manage/case/14366/