Closed
Bug 988765
Opened 11 years ago
Closed 8 years ago
Reftest fails - reftests/marquee/166591-dynamic-1.html
Categories
(Testing :: Reftest, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: vichen, Unassigned)
References
Details
Attachments
(2 files, 2 obsolete files)
|
16.98 KB,
text/plain
|
Details | |
|
1.75 KB,
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
No description provided.
It might be a timing issue.
<body onload="init();">
Replace onload by MozReftestInvalidate
Attachment #8455181 -
Attachment is obsolete: true
Comment on attachment 8455194 [details] [diff] [review]
Do validation test after receive MozReftestInvalidate event
Review of attachment 8455194 [details] [diff] [review]:
-----------------------------------------------------------------
Hi Ahal,
In this patch, rather then do the test in onload event, I use MozReftestInvalidate to prevent timing issue. Please help to review, thanks
Attachment #8455194 -
Flags: review?(ahalberstadt)
Also remove random-if condition of this test case
Attachment #8455194 -
Attachment is obsolete: true
Attachment #8455194 -
Flags: review?(ahalberstadt)
Attachment #8455391 -
Flags: review?(ahalberstadt)
Try result.
https://tbpl.mozilla.org/?tree=Try&rev=08531f23b732
R14
02:48:15 INFO - REFTEST TEST-START | http://10.0.2.2:8888/tests/layout/reftests/marquee/166591-dynamic-1.html
02:48:15 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8888/tests/layout/reftests/marquee/166591-dynamic-1.html | 10 / 616 (1%)
02:48:15 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8888/tests/layout/reftests/marquee/166591-dynamic-1-ref.html | 10 / 616 (1%)
02:48:15 INFO - REFTEST TEST-PASS(EXPECTED RANDOM) | http://10.0.2.2:8888/tests/layout/reftests/marquee/166591-dynamic-1.html | image comparison (==)
Have submit 10 more round. let's double check the result
PS
This try was submitted before removing random-if condition, so we have to look into full log to make sure it does pass
|
||
Updated•10 years ago
|
Attachment #8455391 -
Flags: review?(ahalberstadt) → review+
|
||
Comment 7•8 years ago
|
||
This is WONTFIX (i.e. we're not going to invest in enabling/fixing reftests on B2G), now that we're removing B2G code from the tree via bug 1306391. The reftest annotation got removed in bug 1307332.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•