Closed Bug 988907 Opened 10 years ago Closed 10 years ago

Context menu and clicking-to-focus do not work in empty space above/below newtab grid

Categories

(Firefox :: Tabbed Browser, defect)

Product:
Firefox
Component:
Tabbed Browser
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 31
Tracking Flags:
Tracking Status
firefox31 --- verified

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

(Whiteboard: p=1 s=it-31c-30a-29b.3 [qa!]) 

{V}: Mardak, the new xul:spacers on about:newtab don't show the context menu on right click

I guess context menus don't like xul elements. Switching to <div style="display: -moz-box; -moz-box-flex: 1"> from <xul:spacer flex="1"/> should probably work.
{V}: Mardak, <div style="display: -moz-box; -moz-box-flex: 1"> like you suggest does seem to work. (tested by live editing in Inspector) No change in visual layout, but rightclick functionality is restored.
Bug 962490 has a patch that fixes this issue.
Depends on: 962490
The spacers are also not left-clickable, which makes it harder to focus the content area (to defocus the address bar, or to press Ctrl+Shift+A, if that matters).
QA Whiteboard: [bugday-20140407]
Summary: Context menu does not work in empty space above/below newtab grid → Context menu and clicking-to-focus do not work in empty space above/below newtab grid
Depends on: 994185
Flags: firefox-backlog+
Fixed by bug 994185 https://hg.mozilla.org/mozilla-central/rev/f1ad078b79e5
Assignee: nobody → edilee
Blocks: tiles-dev
Status: NEW → RESOLVED
Closed: 10 years ago
No longer depends on: 962490
Resolution: --- → FIXED
Whiteboard: p=1 s=it-31c-30a-29b.3
Hi Liz, can you review if this bug requires further QA verification [qa+] or not [qa-].
Flags: needinfo?(lhenry)
Whiteboard: p=1 s=it-31c-30a-29b.3 → p=1 s=it-31c-30a-29b.3 [qa?]
Verified with 2014-04-20-03-02-02-mozilla-central-firefox-31.0a1.en-US.linux-x86_64 compared to 2014-04-17-03-02-03-mozilla-central-firefox-31.0a1.ru.linux-x86_64.
Status: RESOLVED → VERIFIED
Target Milestone: --- → Firefox 31
Aleksej, I'd verify it for 31 but not necessarily for other versions. I'll pass this on to tracy since I think that he's QA contact for Tiles and other newtab features.
Status: VERIFIED → RESOLVED
Closed: 10 years ago → 10 years ago
status-firefox29: --- → affected
status-firefox30: --- → affected
status-firefox31: --- → verified
QA Contact: twalker
Whiteboard: p=1 s=it-31c-30a-29b.3 [qa?] → p=1 s=it-31c-30a-29b.3 [qa+]
Flags: needinfo?(lhenry)
QA Contact: twalker → cornel.ionce
Status: RESOLVED → VERIFIED
I'm setting [qa!] since it seems there's no more QA work needed for this issue. Please set it back if you think otherwise.
Whiteboard: p=1 s=it-31c-30a-29b.3 [qa+] → p=1 s=it-31c-30a-29b.3 [qa!]
You need to log in before you can comment on or make changes to this bug.