98892 - Plugin downloader crashes browser if another plugin is already installed

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[sven.papperitz]

If you use the JAVA beta plugin from IBM for Netscape 6.1 and you enter an
website which requests for another plugin, e.g. shockwave, it will crash the
browser. Don't have other plugins for AIX, so I'm not sure if it's an problem of
the JAVA plugin or Mozilla on AIX. 
If you don't use the plugin you will get the normal window asking you for
downloading the required plugin.

Comment 1

[Markus Gerstel]

Please observe the Bug Writing Guidelines and _at least_ include your BuildID in
the report. Thank you for testing Mozilla.

Comment 2

[Keyser Sose]

Marking these all WORKSFORME sorry about lack of response but were very
overloaded here. Only reopen the bug if you can reproduce with the following steps:

1) Download the latest nightly (or 0.9.6 which should be out RSN)
2) Create a new profile
3) test the bug again

If it still occurs go ahead and reopen the bug. Again sorry about no response
were quite overloaded here and understaffed.

Comment 3

[Christopher Hoess (gone)]

reopening

Comment 4

[Christopher Hoess (gone)]

not enough info to determine bug, INVALID.

Comment 5

[Jim Dunn]

I am reopening this since it happens in 0.9.9.
If you have the java plugin and go to www.cinestar.de
you get a browser crash (no core) and I see a gtk msg.

I need to check this out on other platforms...

Comment 6

[Philip K. Warren]

*** Bug 112937 has been marked as a duplicate of this bug. ***

Comment 7

[Philip K. Warren]

Reassigning bug to me. We have a patch which resolves this problem on AIX.

Comment 8

[Philip K. Warren]

Attachment: Add -lXm to link flags before -lXt

We tracked this down to a problem with mixing programs linked with libXt and
ones linked with libXm (like the java plugin). If we link with libXm before
libXt, these crashes no longer occur.

Comment 9

[hacker formerly known as [e-mail]]

Comment on attachment 100013 [details] [diff] [review]
Add -lXm to link flags before -lXt

Can you add a comment to each of those Makefiles explaining why we need to link
against Motif.	

Or even better, just add -lXm to XT_LIBS in configure and make those stray
spots use XT_LIBS instead of hardcoding -lXt.

Comment 10

[Philip K. Warren]

Attachment: Use XT_LIBS instead of hardcoding -lXt

New patch which uses XT_LIBS and removes usage of -lXt in last remaining
makefiles.

Comment 11

[hacker formerly known as [e-mail]]

Comment on attachment 100925 [details] [diff] [review]
Use XT_LIBS instead of hardcoding -lXt

r=cls

Comment 12

[Philip K. Warren]

Checked in:

Checking in configure.in;C written                  
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1107; previous revision: 1.1106
done
Checking in modules/plugin/base/src/Makefile.in;
/cvsroot/mozilla/modules/plugin/base/src/Makefile.in,v  <--  Makefile.in
new revision: 1.74; previous revision: 1.73
done
Checking in modules/plugin/samples/default/unix/Makefile.in;
/cvsroot/mozilla/modules/plugin/samples/default/unix/Makefile.in,v  <--  Makefile.in
new revision: 1.21; previous revision: 1.20
done
Checking in widget/src/gtkxtbin/Makefile.in;
/cvsroot/mozilla/widget/src/gtkxtbin/Makefile.in,v  <--  Makefile.in
new revision: 1.9; previous revision: 1.8
done

Comment 13

[Philip K. Warren]

Verified in today's build.