989126 - Add Gaia build tests to TBPL

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[Jonathan Griffin (:jgriffin)]

+++ This bug was initially created as a clone of Bug #989125 +++

We want to add Gaia build tests to TBPL, so we can stop using Travis.  These tests use a make target similar to gaia-integration, so we should be able to use a mozharness script that's very similar.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Add mozharness script for gaia-build-integration tests,

We don't need a new config file, we can use the existing gaia_unit config file, which is already used for gaia-integration.

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 8398584 [details] [diff] [review]
Add mozharness script for gaia-build-integration tests,

Review of attachment 8398584 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, that's really simple! One minor suggestion.

::: scripts/gaia_build_integration.py
@@ +35,5 @@
> +            os.path.join(dirs['abs_gaia_dir'], 'b2g'),
> +            overwrite='clobber'
> +        )
> +
> +        self.make_node_modules()

I think we should just add 'make_node_modules' as a new action in the GaiaTest class.

@@ +42,5 @@
> +          config=self.config, log_obj=self.log_obj, error_list=self.error_list)
> +
> +        # `make test-integration \
> +        #      MOCHA_REPORTER=mocha-tbpl-reporter \
> +        #      NPM_REGISTRY=http://npm-mirror.pub.build.mozilla.org`

nit: this comment still references the other script

::: scripts/gaia_integration.py
@@ +36,4 @@
>              overwrite='clobber'
>          )
>  
> +        self.make_node_modules()

See above comment.

Comment 3

[Jonathan Griffin (:jgriffin)]

This will be slightly tricky.  Changing the default actions will require separating the config files used for gaia-unit tests (which don't use node) and gaia-integration tests (which do).  Using different config files requires changing buildbot-configs.

I've landed a version of this patch on ash-mozharness which introduces a new config file (but doesn't use it), and leaves the default actions as-is.  Assuming this goes green, I'll land it, then make some buildbot-configs adjustments, and then finally roll the make_node_modules code into a separate action.

Comment 4

[Jonathan Griffin (:jgriffin)]

Ash is good, so:  https://hg.mozilla.org/build/mozharness/rev/589e569b40a3

buildbot-configs next!

Comment 5

[John Hopkins (:jhopkins)]

in production.

Comment 6

[Jonathan Griffin (:jgriffin)]

Attachment: Schedule gaia-build tests on ash; use gaia_integration_config.py for gaia-integration tests,

This patch does two things; it makes us use gaia_integration_config.py for gaia-integration tests (which were previously using gaia_unit_production_config.py), and it schedules gaia-build on ash so I can play with mozharness changes there.

Comment 7

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/build/buildbot-configs/rev/5fa957581b6b

Comment 8

[Gregor Wagner [:gwagner]]

Seems like all the dependencies are fixed here \o/
What are the next steps? Seems like they are green on ash.
Can we enable them on other inbound trees as well now?

Comment 9

[Armen [:armenzg]]

Is this the build we're talking about? I think so. Just double checking.
https://tbpl.mozilla.org/?tree=Ash&jobname=gaia-build

We should enable on b2g-inbound and m-i to see them running at scale *hidden*.
Once we see them running them at scale without any intermintency we should be able to enable it across trunk trees.

Work for you?

Comment 10

[Armen [:armenzg]]

Attachment: [checked-in] gaia_build.diff

Comment 11

[Gregor Wagner [:gwagner]]

(In reply to Armen Zambrano (off on Friday 9th) [:armenzg] (EDT/UTC-4) from comment #9)
> Is this the build we're talking about? I think so. Just double checking.
> https://tbpl.mozilla.org/?tree=Ash&jobname=gaia-build
> 

Yes!

> We should enable on b2g-inbound and m-i to see them running at scale
> *hidden*.
> Once we see them running them at scale without any intermintency we should
> be able to enable it across trunk trees.
> 
> Work for you?

Sounds good to me.
Thanks!

Comment 12

[Armen [:armenzg]]

Comment on attachment 8418844 [details] [diff] [review]
[checked-in] gaia_build.diff

https://hg.mozilla.org/build/buildbot-configs/rev/a89c4356167c

Once buildduty merges this change to production we will see it running live.
A comment will be placed in here to indicate so.

Comment 13

[Chris Cooper [:coop] (he/him)]

(In reply to Armen Zambrano (off on Friday 9th) [:armenzg] (EDT/UTC-4) from comment #12)
> Once buildduty merges this change to production we will see it running live.
> A comment will be placed in here to indicate so.

Merged and deployed to production.

Comment 14

[Gregor Wagner [:gwagner]]

Thanks for the quick turnaround!

Comment 15

[Armen [:armenzg]]

gwagner: these jobs are running well; ready to enable it across all trunk trees?

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&jobname=gaia-build
https://tbpl.mozilla.org/?tree=B2g-Inbound&jobname=gaia-build

Comment 16

[Jonathan Griffin (:jgriffin)]

Yes, we should enable on all trunk trees (including gaia-try)

Comment 17

[Armen [:armenzg]]

Attachment: enable on trunk builds

Comment 18

[Jordan Lund (:jlund)]

Comment on attachment 8421975 [details] [diff] [review]
enable on trunk builds

Review of attachment 8421975 [details] [diff] [review]:
-----------------------------------------------------------------

IIUC I think we will need to delete the GAIA_BUILD refs on ash[1] and cedar[2] if we are to do this. Otherwise, we will have duplicate builder names.

[1] http://hg.mozilla.org/build/buildbot-configs/file/50f3140e4392/mozilla-tests/b2g_config.py#l1597
[2] http://hg.mozilla.org/build/buildbot-configs/file/50f3140e4392/mozilla-tests/b2g_config.py#l1608

Comment 19

[Jonathan Griffin (:jgriffin)]

Attachment: [backed out] Schedule gaia-build on all trunk branches,

Removed GAIA_BUILD special-casing from ash and cedar

Comment 20

[Jordan Lund (:jlund)]

Comment on attachment 8422770 [details] [diff] [review]
[backed out] Schedule gaia-build on all trunk branches,

Review of attachment 8422770 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm :)

Comment 21

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/build/buildbot-configs/rev/a616d7ead7dd

Comment 22

[Chris AtLee [:catlee]]

We should probably hold off deploying this. We're having a builder explosion problem. See bug 1009880

Comment 23

[Jordan Lund (:jlund)]

should I back out or did removing three branches make this insignificant?

Comment 24

[Jordan Lund (:jlund)]

jgriffin :(

I backed this out for now: https://hg.mozilla.org/build/buildbot-configs/rev/6bfbe3739dcb

We can land again once we find a solution in bug 1009880

Comment 25

[Jonathan Griffin (:jgriffin)]

Ok.  FYI this will block gaia-try from being used in place of Travis, but I don't think it's the only blocker atm.

Comment 26

[Jonathan Griffin (:jgriffin)]

We now have extra linux64 builders, so re-landed as https://hg.mozilla.org/build/buildbot-configs/rev/058d933ba590

Comment 27

[Justin Wood (:Callek)]

Something here went live today