Closed Bug 989126 Opened 6 years ago Closed 6 years ago

Add Gaia build tests to TBPL

Categories

(Firefox OS Graveyard :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jgriffin, Assigned: jgriffin)

References

Details

(Keywords: ateam-b2g-task)

Attachments

(3 files, 2 obsolete files)

+++ This bug was initially created as a clone of Bug #989125 +++

We want to add Gaia build tests to TBPL, so we can stop using Travis.  These tests use a make target similar to gaia-integration, so we should be able to use a mozharness script that's very similar.
Assignee: nobody → jgriffin
We don't need a new config file, we can use the existing gaia_unit config file, which is already used for gaia-integration.
Attachment #8398584 - Flags: review?(ahalberstadt)
Comment on attachment 8398584 [details] [diff] [review]
Add mozharness script for gaia-build-integration tests,

Review of attachment 8398584 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, that's really simple! One minor suggestion.

::: scripts/gaia_build_integration.py
@@ +35,5 @@
> +            os.path.join(dirs['abs_gaia_dir'], 'b2g'),
> +            overwrite='clobber'
> +        )
> +
> +        self.make_node_modules()

I think we should just add 'make_node_modules' as a new action in the GaiaTest class.

@@ +42,5 @@
> +          config=self.config, log_obj=self.log_obj, error_list=self.error_list)
> +
> +        # `make test-integration \
> +        #      MOCHA_REPORTER=mocha-tbpl-reporter \
> +        #      NPM_REGISTRY=http://npm-mirror.pub.build.mozilla.org`

nit: this comment still references the other script

::: scripts/gaia_integration.py
@@ +36,4 @@
>              overwrite='clobber'
>          )
>  
> +        self.make_node_modules()

See above comment.
Attachment #8398584 - Flags: review?(ahalberstadt) → review+
This will be slightly tricky.  Changing the default actions will require separating the config files used for gaia-unit tests (which don't use node) and gaia-integration tests (which do).  Using different config files requires changing buildbot-configs.

I've landed a version of this patch on ash-mozharness which introduces a new config file (but doesn't use it), and leaves the default actions as-is.  Assuming this goes green, I'll land it, then make some buildbot-configs adjustments, and then finally roll the make_node_modules code into a separate action.
Ash is good, so:  https://hg.mozilla.org/build/mozharness/rev/589e569b40a3

buildbot-configs next!
in production.
This patch does two things; it makes us use gaia_integration_config.py for gaia-integration tests (which were previously using gaia_unit_production_config.py), and it schedules gaia-build on ash so I can play with mozharness changes there.
Attachment #8403580 - Flags: review?(aki)
Attachment #8403580 - Flags: review?(aki) → review+
Status: NEW → ASSIGNED
Keywords: ateam-b2g-task
Priority: -- → P1
Depends on: 997491
Depends on: 999062
Seems like all the dependencies are fixed here \o/
What are the next steps? Seems like they are green on ash.
Can we enable them on other inbound trees as well now?
Flags: needinfo?(armenzg)
Is this the build we're talking about? I think so. Just double checking.
https://tbpl.mozilla.org/?tree=Ash&jobname=gaia-build

We should enable on b2g-inbound and m-i to see them running at scale *hidden*.
Once we see them running them at scale without any intermintency we should be able to enable it across trunk trees.

Work for you?
Flags: needinfo?(armenzg)
Attached patch [checked-in] gaia_build.diff (obsolete) — Splinter Review
Attachment #8418844 - Flags: review?(aki)
(In reply to Armen Zambrano (off on Friday 9th) [:armenzg] (EDT/UTC-4) from comment #9)
> Is this the build we're talking about? I think so. Just double checking.
> https://tbpl.mozilla.org/?tree=Ash&jobname=gaia-build
> 

Yes!

> We should enable on b2g-inbound and m-i to see them running at scale
> *hidden*.
> Once we see them running them at scale without any intermintency we should
> be able to enable it across trunk trees.
> 
> Work for you?

Sounds good to me.
Thanks!
Attachment #8418844 - Flags: review?(aki) → review+
Comment on attachment 8418844 [details] [diff] [review]
[checked-in] gaia_build.diff

https://hg.mozilla.org/build/buildbot-configs/rev/a89c4356167c

Once buildduty merges this change to production we will see it running live.
A comment will be placed in here to indicate so.
Attachment #8418844 - Attachment description: gaia_build.diff → [checked-in] gaia_build.diff
(In reply to Armen Zambrano (off on Friday 9th) [:armenzg] (EDT/UTC-4) from comment #12)
> Once buildduty merges this change to production we will see it running live.
> A comment will be placed in here to indicate so.

Merged and deployed to production.
Thanks for the quick turnaround!
Yes, we should enable on all trunk trees (including gaia-try)
Attached patch enable on trunk builds (obsolete) — Splinter Review
Attachment #8421975 - Flags: review?(jlund)
Comment on attachment 8421975 [details] [diff] [review]
enable on trunk builds

Review of attachment 8421975 [details] [diff] [review]:
-----------------------------------------------------------------

IIUC I think we will need to delete the GAIA_BUILD refs on ash[1] and cedar[2] if we are to do this. Otherwise, we will have duplicate builder names.

[1] http://hg.mozilla.org/build/buildbot-configs/file/50f3140e4392/mozilla-tests/b2g_config.py#l1597
[2] http://hg.mozilla.org/build/buildbot-configs/file/50f3140e4392/mozilla-tests/b2g_config.py#l1608
Attachment #8421975 - Flags: review?(jlund) → review-
Removed GAIA_BUILD special-casing from ash and cedar
Attachment #8422770 - Flags: review?(jlund)
Attachment #8418844 - Attachment is obsolete: true
Attachment #8421975 - Attachment is obsolete: true
Comment on attachment 8422770 [details] [diff] [review]
[backed out] Schedule gaia-build on all trunk branches,

Review of attachment 8422770 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm :)
Attachment #8422770 - Flags: review?(jlund) → review+
We should probably hold off deploying this. We're having a builder explosion problem. See bug 1009880
should I back out or did removing three branches make this insignificant?
jgriffin :(

I backed this out for now: https://hg.mozilla.org/build/buildbot-configs/rev/6bfbe3739dcb

We can land again once we find a solution in bug 1009880
Attachment #8422770 - Attachment description: Schedule gaia-build on all trunk branches, → [backed out] Schedule gaia-build on all trunk branches,
Ok.  FYI this will block gaia-try from being used in place of Travis, but I don't think it's the only blocker atm.
We now have extra linux64 builders, so re-landed as https://hg.mozilla.org/build/buildbot-configs/rev/058d933ba590
Something here went live today
Depends on: 1013585
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.