989172 - Homescreen sandbox crash on QRD kitkat (again)

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Diego Wilson [:diego]]

It looks like SECCOMP support has regressed once more at the tip of m-c. We're seeing messages like this with m-c when we enable SECCOMP in our kernel:

E/Sandbox ( 1229): seccomp sandbox violation: pid 1229, syscall 186, args       >3003121052 0 0 3 3742896 0.  Killing process.

SECCOMP on the v1.4 branch still works fine.

See bug 983518 for details on how to create a SECCOMP enabled build.

Comment 1

[Diego Wilson [:diego]]

Guillaume,

Any idea of what could've caused the regression?

Comment 2

[Diego Wilson [:diego]]

FWIW I can see the commit from bug 983518 in my m-c build, so it's not a case of a missing patch.

Comment 3

[Guillaume Destuynder [:kang] [this account is no longer active]]

the patch in bug 983518 should fix that exact issue. 186 is sigaltstack on ARM.

what device are you running this on?

Comment 4

[Diego Wilson [:diego]]

(In reply to Guillaume Destuynder [:kang] (use NEEDINFO!) from comment #3)
> the patch in bug 983518 should fix that exact issue. 186 is sigaltstack on
> ARM.

Exactly! To reiterate, the patch was working fine at least for a while and in fact is still working great on v1.4. Alas, I think a later patch broke it. I did notice the contents of seccomp_filter.h got moved around. Maybe something got messed up in the process?

> 
> what device are you running this on?

QRD 8926, same as the one mvines used to report bug 983518
QRD 
QRD 8

Comment 5

[Guillaume Destuynder [:kang] [this account is no longer active]]

oh, ok i understand now.

Indeed. its missing from the new layout (http://hg.mozilla.org/mozilla-central/file/6fa163ff81a3/security/sandbox/linux/SandboxFilter.cpp)
I didn't notice when reviewing :(

Comment 6

[Preeti Raghunath(:Preeti)]

Paul

Please take a look from security standpoint

Comment 7

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: bug989172-oops-hg0.diff

Comment 8

[Guillaume Destuynder [:kang] [this account is no longer active]]

Comment on attachment 8398679 [details] [diff] [review]
bug989172-oops-hg0.diff

Review of attachment 8398679 [details] [diff] [review]:
-----------------------------------------------------------------

thanks jld!

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/47cbfabd27b4

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/47cbfabd27b4