Closed Bug 989172 Opened 6 years ago Closed 6 years ago

Homescreen sandbox crash on QRD kitkat (again)

Categories

(Core :: Security, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: diego, Assigned: jld)

References

Details

(Whiteboard: [cr 631673])

Attachments

(1 file)

It looks like SECCOMP support has regressed once more at the tip of m-c. We're seeing messages like this with m-c when we enable SECCOMP in our kernel:

E/Sandbox ( 1229): seccomp sandbox violation: pid 1229, syscall 186, args       >3003121052 0 0 3 3742896 0.  Killing process.

SECCOMP on the v1.4 branch still works fine.

See bug 983518 for details on how to create a SECCOMP enabled build.
Guillaume,

Any idea of what could've caused the regression?
Flags: needinfo?(gdestuynder)
FWIW I can see the commit from bug 983518 in my m-c build, so it's not a case of a missing patch.
the patch in bug 983518 should fix that exact issue. 186 is sigaltstack on ARM.

what device are you running this on?
Flags: needinfo?(gdestuynder)
(In reply to Guillaume Destuynder [:kang] (use NEEDINFO!) from comment #3)
> the patch in bug 983518 should fix that exact issue. 186 is sigaltstack on
> ARM.

Exactly! To reiterate, the patch was working fine at least for a while and in fact is still working great on v1.4. Alas, I think a later patch broke it. I did notice the contents of seccomp_filter.h got moved around. Maybe something got messed up in the process?

> 
> what device are you running this on?

QRD 8926, same as the one mvines used to report bug 983518
QRD 
QRD 8
Flags: needinfo?(gdestuynder)
oh, ok i understand now.

Indeed. its missing from the new layout (http://hg.mozilla.org/mozilla-central/file/6fa163ff81a3/security/sandbox/linux/SandboxFilter.cpp)
I didn't notice when reviewing :(
Flags: needinfo?(gdestuynder) → needinfo?(jld)
Paul

Please take a look from security standpoint
Flags: needinfo?(ptheriault)
Assignee: nobody → jld
Attachment #8398679 - Flags: review?(gdestuynder)
Flags: needinfo?(ptheriault)
Flags: needinfo?(jld)
Comment on attachment 8398679 [details] [diff] [review]
bug989172-oops-hg0.diff

Review of attachment 8398679 [details] [diff] [review]:
-----------------------------------------------------------------

thanks jld!
Attachment #8398679 - Flags: review?(gdestuynder) → review+
https://hg.mozilla.org/mozilla-central/rev/47cbfabd27b4
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.