Closed
Bug 989303
Opened 11 years ago
Closed 11 years ago
dom/wifi/WifiUtils.cpp:17:0: warning: "PROPERTY_VALUE_MAX" redefined [enabled by default]
Categories
(Firefox OS Graveyard :: Wifi, defect)
Tracking
(tracking-b2g:backlog)
People
(Reporter: vicamo, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.45 KB,
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
||
Updated•11 years ago
|
blocking-b2g: --- → backlog
|
Assignee | |
Updated•11 years ago
|
|
|
Assignee | |
Comment 1•11 years ago
|
||
> gecko/dom/wifi/WifiUtils.cpp:16:1: warning: "PROPERTY_VALUE_MAX" redefined
> system/core/include/cutils/properties.h:32:1: warning: this is the location of the previous definition
Fabrice, is there a reason you #defined PROPERTY_VALUE_MAX in your WifiUtils.cpp patch for bug 909065 when this macro is already #defined in Android's cutils/properties.h? Also, your PROPERTY_VALUE_MAX is 80 whereas Android's is 92:
PROPERTY_VALUE_MAX is #defined in https://github.com/android/platform_system_core/blob/master/include/cutils/properties.h#L37
> #define PROPERTY_VALUE_MAX PROP_VALUE_MAX
and PROP_VALUE_MAX is #defined in https://github.com/android/platform_bionic/blob/master/libc/include/sys/system_properties.h#L39
> #define PROP_VALUE_MAX 92
Attachment #8543598 -
Flags: review?(fabrice)
|
||
Updated•11 years ago
|
Attachment #8543598 -
Flags: review?(fabrice) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S3 (9jan)
|
||
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•