989357 - Recompress the new application icons

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Gabriele Svelto [:gsvelto] (PTO)]

+++ This bug was initially created as a clone of Bug #975535 +++

As per title, the new application icons haven't been recompressed before inclusion, doing so yields a significant reduction in size w/o any visual alterations so let's do it.

Comment 1

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: [PULL REQUEST] Recompressed the new application icons

This pull request contains all the new applications icons duly recompressed with the png_recompress.sh script provided in gaia. The savings are over 40% so this is well worth it. I'm asking for review to everybody involved in the original PR for extra safety. The recompression process is loss-less and the images should be identical but it's always better to double-check.

Comment 2

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8398563 [details] [review]
[PULL REQUEST] Recompressed the new application icons

LGTM from homescreen point of view

Comment 3

[Gregor Wagner [:gwagner]]

Comment on attachment 8398563 [details] [review]
[PULL REQUEST] Recompressed the new application icons

Peter is out this week. I guess we are good to go here.

Comment 4

[Stephany Wilkes]

Flagging Patryk since Peter is out this week, just in case.

Comment 5

[Gabriele Svelto [:gsvelto] (PTO)]

(In reply to Gregor Wagner [:gwagner] from comment #3)
> Peter is out this week. I guess we are good to go here.

Thanks Gregor, I've refreshed the patch because of a conflict with bug 983080 and I'm holding the merge until I've clarified that the file deleted as part of that bug is truly not needed or should be re-introduced.

I've already caught a couple of occurrences in the past few days were we missed a certain asset size or gave it the wrong name (e.g. @2.25.png instead of @2.25x.png). Maybe we should introduce a more formal way to specify what images are required by an application so we can ensure the consistency of our assets and prevent similar issues.

Comment 6

[Gabriele Svelto [:gsvelto] (PTO)]

I've confirmed that bug 983080 was missing a file, it's now been fixed so I'll refresh the PR once again and merge it.

Comment 7

[Gabriele Svelto [:gsvelto] (PTO)]

Merged to gaia/master 198df96d9e7263ae6b39d9f96abca877e342640f

Comment 8

[Patryk Adamczyk [:patryk] UX]

Visually the graphics look good to me. Sorry for the extra work, I reminded my team to make sure they are submitting compressed graphics. Thanks guys.

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Uplifted to 1.4: https://github.com/mozilla-b2g/gaia/commit/c6fd6e9b5f857eafbf532f0413145d4f4d302217