989532 - Main menu quickshare and context menu "Share link" should use same history

Status: RESOLVED DUPLICATE of bug 990364

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

I got some feedback that sounded like we wanted the quickshare in our main menu, and the quickshare on links to match.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 8398818 [details] [diff] [review]
Patch

This makes us use the default filename if you're using the default mimetype (or no mimetype at all...). Also checking with UX. Is this what we want?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8398818 [details] [diff] [review]
Patch

Just to be clear:
* The main menu "share" is for the Page URL and uses "text/plain"
* The context menu "share" for LINKs is for Page URLs and uses "text/plain"

That is what we want. We also want this for any other "share" that passes a Page URL.

Comment 4

[Ian Barlow (:ibarlow)]

(In reply to Wesley Johnston (:wesj) from comment #2)
> Comment on attachment 8398818 [details] [diff] [review]
> Patch
> 
> This makes us use the default filename if you're using the default mimetype
> (or no mimetype at all...). Also checking with UX. Is this what we want?

Sorry Wes, I don't quite understand what you're asking me here...

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Wes - See comment 3 and comment 4

Comment 6

[Wesley Johnston (:wesj)]

I wound up doing this in bug 990364. Context menu links and the main menu now use text/plain for their mimetype, and all use the default history file. tel: and mailto: links will also use it (since, AFAICT, no apps specifically target those mime types).

Resolving this as a dup.

Comment 7

[Wesley Johnston (:wesj)]

Comment on attachment 8398818 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New feature. Needed for 942270 to be uplifted
User impact if declined: No quickshare in context menus
Testing completed (on m-c, etc.): This has been on central for a few weeks. I think it (along with its fixed dependencies) are enough to move it forward.
Risk to taking this patch (and alternatives if risky): This is medium risk. Alternatives are to hold this back a release, but we've really wanted this in 30.
String or IDL/UUID changes made by this patch: None. I landed the strings in 30.

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8398818 [details] [diff] [review]
Patch

this looks like a different patch than in the dupe bug so approving for uplift.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Bug 942270 was uplifted without this fix. Is this still needed?

Comment 10

[Wesley Johnston (:wesj)]

No. I don't think it is. Sorry for the confusion :(