990364 - Share options have dramatically shrunk

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

Attachment: Screenshot_2014-03-31-20-01-06.png

A whole bunch of my usual share destinations have gone missing in recent Nightly. I no longer have Pocket, Twitter, Facebook… 

It looks like we take the first 11 results and stop.

Relaunching Nightly didn't help. 

Sharing from other apps shows my full list, so this only affects Firefox.

Comment 1

[Aaron Train [:aaronmt]]

Don't see this; I have a full listing (Nexus 5, 4.4.2). I cross checked 03/31 and 04/01.

Comment 2

[Aaron Train [:aaronmt]]

See this. The list gets chopped on access to context-menu quickshare.

Comment 3

[Aaron Train [:aaronmt]]

New profile

* Launch Firefox
* Tap Marketplace
* Long tap on any link, tap share link
* See missing items

Open the Share menu, see same missing items

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Patch

This moves all of our share handlers to text/plain and uses the DEFAULT history file for all text/* handlers.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8400866 [details] [diff] [review]
Patch

r+ with the assumption that you saw this fix the issue. If this is a good guess, I'd like to get an APK for Aaron (or somebody) to see if it fixes the issue.

Comment 6

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/47cfc15df7e9

I did see this fix the issue.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/47cfc15df7e9

Comment 9

[Wesley Johnston (:wesj)]

Comment on attachment 8400866 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New feature. Needed if we want to uplift 942270.
User impact if declined: No quickshare in context menus
Testing completed (on m-c, etc.): This has been on central for a few weeks. I think it (along with its fixed dependencies) are enough to move it forward.
Risk to taking this patch (and alternatives if risky): This is medium risk. Alternatives are to hold this back a release, but we've really wanted this in 30.
String or IDL/UUID changes made by this patch: None. I landed the strings in 30.

Comment 10

[u421692]

Verified as fixed on Nightly 31.0a1(2104-04-14)

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/655c2f12da34

Comment 12

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed on Aurora 30.0a2 (2014-04-17)

Comment 13

[Teodora Vermesan (:TeoVermesan)]

Based on comment 10&12 I will mark this bug as verified fixed.