989580 - Lazy load BrowserElementParent.jsm in BrowserElementParent.js

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

BrowserElementParent.js only needs BrowserElementParent.jsm if "dom.mozBrowserFramesEnabled=true" which is only true for B2G, it seems.

Otherwise, BrowserElementParent.jsm and BrowserElementPromptService.jsm (via BrowserElementParent.jsm) are loaded but never used. Those two take up >80KB together in about:memory as well as affect startup performance.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Lazy load BrowserElementParent.jsm in BrowserElementParent.js. v1

This ought to do the trick...

Comment 2

[Richard Newman [:rnewman]]

Try all green:

https://tbpl.mozilla.org/?tree=Try&rev=fdf651db884a

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8399165 [details] [diff] [review]
Lazy load BrowserElementParent.jsm in BrowserElementParent.js. v1

Whoops, missed a bit.

Comment 4

[Richard Newman [:rnewman]]

Attachment: Lazy load BrowserElementParent.jsm in BrowserElementParent.js. v2

Now with more actually-doing-what-it-should.

Comment 5

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/b5bcfca4bf5b

mfinkle, keep an eye on AWSY and startup perf, see if this is measurable enough to warrant hopping to Aurora?

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b5bcfca4bf5b