Closed Bug 989650 Opened 9 years ago Closed 9 years ago

backport bug 294021 to bmo/4.2 to allow requestees to set attachment flags even if they don't have editbugs privs

Categories

(bugzilla.mozilla.org :: General, enhancement)

Product:
bugzilla.mozilla.org
Component:
General
Version:
Production
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: dkl, Assigned: dkl)

References

Details

Attachments

(1 file)

294021_1.patch
8.98 KB, patch
glob
: review+
Details | Diff | Splinter Review 
SSIA
Attached patch 294021_1.patch — — Splinter Review 

        Attachment #8398974 -
        Flags: review?(glob)

    
    

    
  
Comment on attachment 8398974 [details] [diff] [review]
294021_1.patch

Review of attachment 8398974 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob, with $attachment --> $self on commit

::: Bugzilla/Attachment.pm
@@ +713,5 @@
>  
>  =cut
>  
>  sub validate_can_edit {
> +    my $attachment = shift;

rename $attachment to $self in this method.

        Attachment #8398974 -
        Flags: review?(glob) → review+

    
    

    
  
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   8e4cf05..71927e7  4.2 -> 4.2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.