989660 - Inconsistent transition in menu buttons on Windows 8

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[henryfhchan]

User Agent: Mozilla/5.0 (Linux; Android 4.1.2; LG-E988 Build/JZO54K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/33.0.1750.170 Mobile Safari/537.36

Steps to reproduce:

For menubuttons and the star/bookmarks menu button, the border (or box-shadow) of the buttons fade out at different intervals.  It seems the border of the left button transitions out nicely while that on the right is always sharp.

Hovering and unhovering over the buttons repeatedly (about after 10 or so times) seem to reduce the effect.

Comment 1

[Tim Nguyen :ntim]

Thanks for filling the bug :) Gonna fix this after fixing bug 989449

Comment 2

[Justin Dolske [:Dolske]]

FWIW, I don't see this on OS X.

Comment 3

[Tim Nguyen :ntim]

Fixing bug 989449 should fix the problem for Windows XP, Vista and 7.

Comment 4

[henryfhchan]

Actually, shouldn't the negative margin be set on the tabbar instead of the navigation toolbar? This alternative approach avoids all the CSS **** in adding an additional margin or padding to items who protruded into the border....

Comment 5

[Tim Nguyen :ntim]

(In reply to henryfhchan from comment #4)
> Actually, shouldn't the negative margin be set on the tabbar instead of the
> navigation toolbar? This alternative approach avoids all the CSS **** in
> adding an additional margin or padding to items who protruded into the
> border....

I think you're commenting on the wrong bug.

Comment 6

[henryfhchan]

Oops yes ;(

Comment 7

[:Gijs (out for now; he/him)]

This doesn't need to be P3- if it's Win8 only (per comment #3)

Comment 8

[David Nelson]

Hi

Could you assign me this bug please?

Thanks,
David

Comment 9

[Saurabh Anand [:sawrubh]]

David, we normally try to assign bugs once you have a patch up (so as to prevent a bug from getting blocked). Your having commented here should stop others from taking this up. So feel free to post a patch (or ask questions) and I'll be happy to assign this to you after that.

Comment 10

[David Nelson]

Hi Saurabh,

I cannot see the code - do you know where it is located?

Thanks
David

Comment 11

[Saurabh Anand [:sawrubh]]

Sorry, I'm not too familiar with this codebase so I'll ask the mentors (I'm needinfo-ing them). In the meanwhile if I were you, I would take a look at other related to (try and) figure out the file in which changes are to be made. (like bug 989449 probably). BTW if you meant viewing the source code online, you can do that at http://dxr.mozilla.org/mozilla-central/source/. I hope you've already downloaded and built the source.

Comment 12

[Tim Nguyen :ntim]

So it seems this was fixed recently. Sorry I didn't close this bug earlier :/