Closed Bug 989899 Opened 7 years ago Closed 7 years ago

[VDR][Messages] Apply Buttons and Input areas [BB]

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(feature-b2g:2.0, tracking-b2g:backlog)

VERIFIED FIXED
1.4 S5 (11apr)
feature-b2g 2.0
tracking-b2g backlog

People

(Reporter: noemi, Assigned: joan)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
julienw
: review+
arnau
: ui-review+
Details | Review
Apply new buttons and inputs areas BB within Messaging app
Assignee: nobody → joan.leon
Status: NEW → ASSIGNED
Attached file Patch in GitHub
Attachment #8399385 - Flags: ui-review?(arnau)
Attachment #8399385 - Flags: review?(francisco.jordano)
Comment on attachment 8399385 [details] [review]
Patch in GitHub

Forwarding the review to Julienne, as I'm sure he will have more knowledge to all changes done to sms.

Thanks folsk.
Attachment #8399385 - Flags: review?(francisco.jordano) → review?(felash)
Comment on attachment 8399385 [details] [review]
Patch in GitHub

cool thanks!
Attachment #8399385 - Flags: ui-review?(arnau) → ui-review+
Comment on attachment 8399385 [details] [review]
Patch in GitHub

I tried various things but this looks good.

only the MMS download button looks wrong (but not wronger than before) (when MMS auto download is disabled) but maybe bug 926385 will make it better and anyway we can do this in a follow-up.

So r=me !
Attachment #8399385 - Flags: review?(felash) → review+
Merged: 558abc6411b44063f2560b4cb1f8dcbdef16a1c2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S5 (11apr)
(In reply to Julien Wajsberg [:julienw] from comment #4)
> Comment on attachment 8399385 [details] [review]
> Patch in GitHub
> 
> I tried various things but this looks good.
> 
> only the MMS download button looks wrong (but not wronger than before) (when
> MMS auto download is disabled) but maybe bug 926385 will make it better and
> anyway we can do this in a follow-up.
> 
> So r=me !

Did you mean the same wrong 'download' button look that should be fixed in bug 980461?
Exactly :)
blocking-b2g: --- → backlog
feature-b2g: --- → 2.0
Tested and fine
Hamachi
2.0
Gecko-e4bc303
Gaia-27c85c3
Status: RESOLVED → VERIFIED
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.