989899 - [VDR][Messages] Apply Buttons and Input areas [BB]

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Noemí Freire (:noemi)]

Apply new buttons and inputs areas BB within Messaging app

Comment 1

[Joan Leon [:joan]]

Attachment: Patch in GitHub

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8399385 [details] [review]
Patch in GitHub

Forwarding the review to Julienne, as I'm sure he will have more knowledge to all changes done to sms.

Thanks folsk.

Comment 3

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8399385 [details] [review]
Patch in GitHub

cool thanks!

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 8399385 [details] [review]
Patch in GitHub

I tried various things but this looks good.

only the MMS download button looks wrong (but not wronger than before) (when MMS auto download is disabled) but maybe bug 926385 will make it better and anyway we can do this in a follow-up.

So r=me !

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: 558abc6411b44063f2560b4cb1f8dcbdef16a1c2

Comment 6

[Oleg Zasypkin [:azasypkin]]

(In reply to Julien Wajsberg [:julienw] from comment #4)
> Comment on attachment 8399385 [details] [review]
> Patch in GitHub
> 
> I tried various things but this looks good.
> 
> only the MMS download button looks wrong (but not wronger than before) (when
> MMS auto download is disabled) but maybe bug 926385 will make it better and
> anyway we can do this in a follow-up.
> 
> So r=me !

Did you mean the same wrong 'download' button look that should be fixed in bug 980461?

Comment 7

[Julien Wajsberg [:julienw]]

Exactly :)

Comment 8

[Loli (:lolimartinezcr)]

Tested and fine
Hamachi
2.0
Gecko-e4bc303
Gaia-27c85c3