990057 - TypeError: redeclaration of var Promise in m-c Simulator

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Simulator, defect)

Comment 1

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Let me take this one, I'm currently working on 1.5 release and that something to address before releasing the first set of xpis!

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Okay, I'll wait and see how you resolve it here, and then start the process of pasting it into various other addon and builds. :)

Comment 3

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Ensure shipping simulator screen xpcom in b2g desktop package

Comment 4

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Fix Promise exception in simulator.

Comment 5

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Comment on attachment 8399475 [details] [diff] [review]
Ensure shipping simulator screen xpcom in b2g desktop package

Oops wrong bug.

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8399478 [details] [diff] [review]
Fix Promise exception in simulator.

Review of attachment 8399478 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8c3b772518f2

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Either this or bug 990065 made B2G desktop mochitests perma-fail. I backed both out for investigation.
https://hg.mozilla.org/integration/mozilla-inbound/rev/05792ab1e06f

https://tbpl.mozilla.org/php/getParsedLog.php?id=37084445&tree=Mozilla-Inbound

Comment 9

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: aurora patch

Comment 10

[Firefox Commit Bot]

The following changesets are now in Firefox Nightly:

> 8c3b772518f2 Bug 990057 - Fix Promise exception in simulator. r=jryans
> 05792ab1e06f Backed out changeset 65338f03492b (bug 990065) and changeset 8c3b772518f2 (bug 990057) for B2G desktop mochitest failures.

Nightly Build Information:

        ID: 20140402030201
 Changeset: 4941a2ac0786109b08856738019b016a6c5a66a6
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=4941a2ac0786
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central

Download Links:

>         Linux x86: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-i686.tar.bz2
>      Linux x86_64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64.tar.bz2
> Linux x86_64 ASAN: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64-asan.tar.bz2
>               Mac: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.mac.dmg
>             Win32: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win32.installer.exe
>             Win64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win64-x86_64.installer.exe

Previous Nightly Build Information:

        ID: 20140401030203
 Changeset: 1417d180a1d8665b1a91b897d1cc4cc31e7980d4
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=1417d180a1d8
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-01-03-02-03-mozilla-central

Comment 11

[Alexandre Poirot [:ochameau] [PTO back August 21]]

I think this patch is safe, let's confirm this:
  https://tbpl.mozilla.org/?tree=Try&rev=85c5a8c35b64

Comment 12

[Alexandre Poirot [:ochameau] [PTO back August 21]]

(In reply to Alexandre Poirot (:ochameau) from comment #11)
> I think this patch is safe, let's confirm this:
>   https://tbpl.mozilla.org/?tree=Try&rev=85c5a8c35b64

^-- It looks like this patch isn't the culprit for the mochitest failure

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/cd99a3cbba9c

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cd99a3cbba9c

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/22f43bc94980