TypeError: redeclaration of var Promise in m-c Simulator

RESOLVED FIXED in Firefox 30

Status

defect
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: jryans, Assigned: ochameau)

Tracking

unspecified
1.4 S6 (25apr)
Dependency tree / graph

Firefox Tracking Flags

(firefox30 fixed, firefox31 fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

No description provided.
Component: Developer Tools: App Manager → Simulator
Product: Firefox → Firefox OS
Version: Trunk → unspecified
Let me take this one, I'm currently working on 1.5 release and that something to address before releasing the first set of xpis!
Assignee: nobody → poirot.alex
Okay, I'll wait and see how you resolve it here, and then start the process of pasting it into various other addon and builds. :)
Comment on attachment 8399475 [details] [diff] [review]
Ensure shipping simulator screen xpcom in b2g desktop package

Oops wrong bug.
Attachment #8399475 - Attachment is obsolete: true
Attachment #8399475 - Flags: review?(21)
Comment on attachment 8399478 [details] [diff] [review]
Fix Promise exception in simulator.

Review of attachment 8399478 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #8399478 - Flags: review?(jryans) → review+
Keywords: checkin-needed
Posted patch aurora patchSplinter Review
The following changesets are now in Firefox Nightly:

> 8c3b772518f2 Bug 990057 - Fix Promise exception in simulator. r=jryans
> 05792ab1e06f Backed out changeset 65338f03492b (bug 990065) and changeset 8c3b772518f2 (bug 990057) for B2G desktop mochitest failures.

Nightly Build Information:

        ID: 20140402030201
 Changeset: 4941a2ac0786109b08856738019b016a6c5a66a6
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=4941a2ac0786
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central

Download Links:

>         Linux x86: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-i686.tar.bz2
>      Linux x86_64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64.tar.bz2
> Linux x86_64 ASAN: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64-asan.tar.bz2
>               Mac: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.mac.dmg
>             Win32: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win32.installer.exe
>             Win64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win64-x86_64.installer.exe

Previous Nightly Build Information:

        ID: 20140401030203
 Changeset: 1417d180a1d8665b1a91b897d1cc4cc31e7980d4
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=1417d180a1d8
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-01-03-02-03-mozilla-central
I think this patch is safe, let's confirm this:
  https://tbpl.mozilla.org/?tree=Try&rev=85c5a8c35b64
(In reply to Alexandre Poirot (:ochameau) from comment #11)
> I think this patch is safe, let's confirm this:
>   https://tbpl.mozilla.org/?tree=Try&rev=85c5a8c35b64

^-- It looks like this patch isn't the culprit for the mochitest failure
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cd99a3cbba9c
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5 S1 (9may)
Blocks: 976773
You need to log in before you can comment on or make changes to this bug.