990137 - Remove legacy code for conditional breakpoints on the client

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[James Long (:jlongster)]

In bug 812172 we implemented conditional breakpoint functionality in the debugger server. Before that, conditional breakpoints were handled client-side.

We need to keep the client-side handling functionality around so that users connecting to an older server will still have this functionality. Firefox OS does not update very quickly, and we can't remove the client-side functionality and leave them hanging until Firefox OS updates with the new server code.

This bug is a reminder to remove the old client-side code whenever most of the debugger servers have it. That might be a while (maybe end of 2014?), depends on how fast things like Firefox OS are updated.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: patch

It would be nice to remove this obsolete code.

Comment 2

[Jason Laster [:jlast]]

Comment on attachment 9037323 [details] [diff] [review]
patch

Review of attachment 9037323 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/shared/client/breakpoint-client.js
@@ +60,4 @@
>     * Determines if this breakpoint has a condition
>     */
>    hasCondition: function() {
> +    return "condition" in this;

i think we can get rid of hasCondition and getCondition as well

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb17a7e03265
Remove obsolete handling code for client side conditional breakpoints, r=jlast.

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/bb17a7e03265