990229 - Story Breakdown - [Form Autofill] Allow users to opt out of form autofill

Status: RESOLVED DUPLICATE of bug 1304306

(Firefox :: Settings UI, defect, P3)

Description

[Marco Mucci [:MarcoM]]

Breaking down Story into multiple smaller, easier-to-estimate bugs.  These individual bugs are dependencies which block the completion of the whole story.  The team provides point estimates to each of the individual bugs instead of the entire story.

Comment 1

[Matthew N. [:MattN]]

Sevaan, how should this checkbox interact with the existing form history checkbox in the privacy pane when using custom history settings? We should consider putting them on the same pane or combining them into one checkbox IMO.

Comment 2

[Sevaan Franks [:sevaan]]

(In reply to Matthew N. [:MattN] from comment #1)
> Sevaan, how should this checkbox interact with the existing form history
> checkbox in the privacy pane when using custom history settings? We should
> consider putting them on the same pane or combining them into one checkbox
> IMO.

I think putting them in the same Custom history settings pane is a good idea. My original thought was to separate it from that section for the sake of visibility, but I think it would be better in that context.

I think the Search and form history checkboxes should be separate though, so a user can still have search history if they don't want form autofill. What do you think of this?

http://cl.ly/image/1m2B1S0i3H1S

Comment 3

[Matthew N. [:MattN]]

(In reply to Sevaan Franks [:sevaan] from comment #2)
> (In reply to Matthew N. [:MattN] from comment #1)
> > Sevaan, how should this checkbox interact with the existing form history
> > checkbox in the privacy pane when using custom history settings? We should
> > consider putting them on the same pane or combining them into one checkbox
> > IMO.
> 
> I think putting them in the same Custom history settings pane is a good
> idea. My original thought was to separate it from that section for the sake
> of visibility, but I think it would be better in that context.

I agree that the visibility of anything behind the custom history dropdown option is poor but I hoped there was talk to address this in the preference re-org. I believe there are some other checkboxes there to help privacy that we'd like to expose more. Having autofill under privacy does make sense IMO though.

> I think the Search and form history checkboxes should be separate though, so
> a user can still have search history if they don't want form autofill. What
> do you think of this?
> 
> http://cl.ly/image/1m2B1S0i3H1S

Thanks, the layout is fine. Why did you remove "form history" from the checkbox with "search history"? There are forms other than search forms (e.g. an order form with a part # field) where we will still save form history. Does this mockup mean that form history and form autofill are tied to one pref or is form history still tied to searchbar history?

Comment 4

[Sevaan Franks [:sevaan]]

Sorry, please reinstate the "form history" to be with "search history" again. I was trying something with all the form stuff under it's own heading and forget to put that back.

I'd like to hear your thoughts about the other check boxes you think we should expose more. Will ping you on IRC.

Comment 5

[Matthew N. [:MattN]]

Actually, thinking about this some more, I think there are users who won't want to use "custom settings for history" but that will want to manage their profiles so perhaps we should move them both out of the history section? Sorry for not realizing that during my last comment. What do you think?

(In reply to Sevaan Franks [:sevaan] from comment #4)
> I'd like to hear your thoughts about the other check boxes you think we
> should expose more. Will ping you on IRC.

I think the main one to make more visible was the third-party cookie setting when that setting was in the press. It seems like we still haven't rolled out only saving cookies for visited sites to release builds.

Comment 6

[Sevaan Franks [:sevaan]]

Agreed. In fact, that was my initial thinking, hence why the mockups are the way they are. I knew there was a reason I did it, but couldn't remember what it was, and it was just for that - visibility.

Comment 7

[Matthew N. [:MattN]]

So how should we address the inconsistency from comment 1 then?

Should we make a new section called "Forms"? Would the password(s) checkbox(es) move there too? Or do you think we should do your original plan for now and hope people aren't confused when they're looking to disable form history?

Comment 8

[Sevaan Franks [:sevaan]]

First off, thanks for rethinking this. I'd momentarily lost my bearings.

So, I think we go with the original idea for placement, a separate section under the Privacy tab/page.

Title of section: Forms

Options:

[x] Remember Form History
[x] Enable Contact Form Autofill               {Button: Manage Profiles}

The "Contact" has been added to the section option to help users distinguish between the two options, and insinuate that Form Autofill is exclusively for contact information.

Comment 9

[Marco Mucci [:MarcoM]]

Removed from Iteration 33.3

Comment 10

[Luke Chang [:lchang] (inactive)]

Since bug 1304306 is addressing this issue as well, let's set this bug as a duplicate.