990295 - Never redirect to images on CDN (always use FQDN!)

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[Christopher Van Wiemeersch [:cvan]]

1. Load https://marketplace.allizom.org
2. Notice for a collection image, we load from /api/v1/rocketfuel/collections/383/image.png?e5c80b2-533612de
3. https://marketplace.allizom.org/api/v1/rocketfuel/collections/383/image.png?e5c80b2-533612de redirects to https://marketplace-cdn.allizom.org/api/v1/rocketfuel/collections/383/image.png?e5c80b2-533612de
4. Cry because we're redirecting instead of linking directly to a resource on the CDN

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Keep in mind we I think we do this in several places, so try to look around. Thanks!

Comment 2

[Mathieu Pillard [:mat]]

https://github.com/mozilla/zamboni/pull/1907

I couldn't find other places where this would be an issue. There are a couple other APIs returning URLs without domain/protocol, for privacy_policy or versions for instance, but Fireplace doesn't use those and it kinda make sense to keep them that way.

Comment 3

[Wil Clouser [:clouserw]]

good catch!

Comment 4

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/2ef4d769fb09286f77c259dededa815aee3f6078

Coming up with good STR is tricky ; I verified myself that both consumer pages and curation tool weren't broken on -dev and that the API returned an URL with a FQDN, so marking as qa-.