Closed Bug 990680 Opened 10 years ago Closed 10 years ago

Remove extras from GlobalSession constructor

Categories

(Firefox for Android Graveyard :: Android Sync, defect)

Product:
Firefox for Android Graveyard
Component:
Android Sync
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/445
57 bytes, text/x-github-pull-request
rnewman
: review+
Details | Review 
Just a little refactor, but want to get this out of the way before digging in to bigger FxAccountSyncAdapter changes.
rnewman: a quick once over is all that's necessary here.  I haven't done any device testing yet, but that will happen as part of other tickets.
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Attachment #8400109 - Flags: review?(rnewman)
Comment on attachment 8400109 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/445

If it works, looks good to me.
Attachment #8400109 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/mozilla-central/rev/88239f234f09
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Android Background Services → Firefox for Android
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.