990821 - Improve reflow on zoom to a state that is acceptable for release

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

Reflow on zoom was removed from the UI in bug 900564. The initial implementation was bug 710298. I cannot find a meta bug to re-enable the feature so I am filing this.

There are open bugs blocking turning on reflow on zoom for release channels. Needinfo to the product team and/or Brad for a list of bugs that are needed to complete a minimum viable feature. 

The old wiki for this is at https://wiki.mozilla.org/Mobile/Projects/Reflow_on_zoom

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Things that are currently filed and may block the release bug 872139 and bug 870788. Others?

Comment 3

[Deb Richardson [:dria] (plz NEEDINFO)]

Adding Erin to the needinfo - I expect she has a much better grasp of the details here than I do.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

This is a judgement call really, but I landed bug 878935 and bug 868341 with the intention of getting it "good enough." I think Karen agreed, but wanted Ian to weigh in and then things got lost in the shuffle of the holidays and what not

Comment 5

[Karen Rudnitski [:kar]]

In the 04-02 nightly build, it seems broken? Using http://ottawaathleticclub.com/programs/playcare/ as my test site, it doesn't seem to react properly when repeating m reflowing. Ie unresponsive or slow to respond or not adjusting to the right area. Did something break? It used to work really well!

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

Bug 990259?

Comment 7

[Ian Barlow (:ibarlow)]

(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #4)
> This is a judgement call really, but I landed bug 878935 and bug 868341 with
> the intention of getting it "good enough." I think Karen agreed, but wanted
> Ian to weigh in and then things got lost in the shuffle of the holidays and
> what not

Having some difficulty testing this -- when i turn reflow on, I can no longer double tap to zoom in on a column of text, and as such I can't get a reflow to happen.

Comment 8

[Deb Richardson [:dria] (plz NEEDINFO)]

I'm in the same boat as ibarlow - I really have no idea how to test this.  Double-tap to zoom isn't working, and I can't seem to find any specific site where this is something that should be happening.

Could someone give specific steps for testing including some relevant sites?

Comment 9

[Brad Lassey [:blassey] (use needinfo?)]

Ian, the regression that broke this for you was fixed. Can you test again? 

For testing notes, boston.com started sending us mobile content, so that's no longer a good test site. Cnn.com gives us desktop content that winds up causing us to reflow ever so slightly. IMO, that's a good enough test case in that it doesn't jump around and isn't super slow, even though the benefit of reflow is fairly small on CNN.

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #9)
> Ian, the regression that broke this for you was fixed. Can you test again? 
> 
> For testing notes, boston.com started sending us mobile content, so that's
> no longer a good test site. Cnn.com gives us desktop content that winds up
> causing us to reflow ever so slightly. IMO, that's a good enough test case
> in that it doesn't jump around and isn't super slow, even though the benefit
> of reflow is fairly small on CNN.

And... now I'm seeing the broken behavior. We need to nail this down, clearing the NI until we do.

Comment 11

[Deb Richardson [:dria] (plz NEEDINFO)]

Clearing the needinfo on me since there doesn't seem to be anything actually needed from me other than sorting out where this falls in the roadmap (which I'll be working on over the next couple of weeks).

Comment 13

[Kevin Brosnan [Ex-Mozilla]]

wontfix based on Bug 1049063

Comment 14

[Richard Z.]

From a user perspective I don't care how broken the code is internally and whether it is going to be fixed, rewritten or replaced.

Some kind of useful zoom+reflow is badly needed however. How is it possible that it works perfectly with every single Firefox version on the desktop and with the Android 2.3.3 stock browser but not on a product designed to work with mobile devices?