990828 - Display Most recent 10 slaveapi calls, not oldest 10

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Justin Wood (:Callek)]

Attachment: [slave_health] v1

So in slave health we do properly sort the results, and properly list them so newest result is at top, however we stop populating after 10 entries, which means we also stop entering the most-recent ones, if there are more than 10 entries to look at.

This patch also makes sure the requested entry gets sorted in the spot where it was requested, with text for "In Progress" (no code to update the table when its done though)

Note that until Bug 990814 is checked in and deployed the request_time won't be real useful for this sorting.

Comment 1

[John Hopkins (:jhopkins)]

Comment on attachment 8400319 [details] [diff] [review]
[slave_health] v1

Looks good to me.  Just one nit:

+                if (sorted_reboots[i].start_timestamp != 0) {

Remove "!= 0" to match byStartTimestamp comparison higher up.

Comment 2

[Justin Wood (:Callek)]

landed, should deploy automatically.